utils: don't hang when getting first par with nonexistant uri-fragment

When an URL is passed which has a uri-fragment referring to a
nonexisting named ref, the bot should not hang with 100% CPU usage
while trying to match a horribly designed regular expression.

Fix by using a much simpler regexp and post-match.

1 files changed, 9 insertions, 2 deletions

diff --git a/lib/rbot/core/utils/utils.rb b/lib/rbot/core/utils/utils.rb
index 7b1ff7f1..ce5cdea4 100644
--- a/lib/rbot/core/utils/utils.rb
+++ b/lib/rbot/core/utils/utils.rb
@@ -618,11 +618,18 @@ module ::Irc
     # uri_fragment:: the URI fragment of the original request
     #
     def Utils.get_string_html_info(text, opts={})
+      debug "getting string html info"
       txt = text.dup
       title = txt.ircify_html_title
+      debug opts
       if frag = opts[:uri_fragment] and not frag.empty?
-        fragreg = /.*?<a\s+[^>]*name=["']?#{frag}["']?.*?>/im
-        txt.sub!(fragreg,'')
+        fragreg = /<a\s+[^>]*name=["']?#{frag}["']?[^>]*>/im
+        debug fragreg
+        debug txt
+        if txt.match(fragreg)
+          # grab the post-match
+          txt = $'
+        end
       end
       c_opts = opts.dup
       c_opts[:strip] ||= title