diff options
| author | Peter Powell <petpow@saberuk.com> | 2017-11-27 14:13:42 +0000 |
|---|---|---|
| committer | Peter Powell <petpow@saberuk.com> | 2017-11-28 13:48:50 +0000 |
| commit | 25c1319e0d16f4cea707a3b7968b70530a5a333f (patch) | |
| tree | 288a5ea6c92667adb1be88e43bc7fa58057117df /src | |
| parent | bf9a8e8a50c338bfa660382b5fd66064167a1d51 (diff) | |
Add length checking to GetExtBanStatus and m_banexception.
As far as I can tell this is not a problem as all ban masks are
canonicalised but its better to be safe than sorry.
Diffstat (limited to 'src')
| -rw-r--r-- | src/channels.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_banexception.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/channels.cpp b/src/channels.cpp index 9f1eafd0c..df2212a21 100644 --- a/src/channels.cpp +++ b/src/channels.cpp @@ -476,7 +476,7 @@ ModResult Channel::GetExtBanStatus(User *user, char type) return rv; for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++) { - if (i->data[0] == type && i->data[1] == ':') + if (i->data.length() > 2 && i->data[0] == type && i->data[1] == ':') { std::string val = i->data.substr(2); if (CheckBan(user, val)) diff --git a/src/modules/m_banexception.cpp b/src/modules/m_banexception.cpp index 1811f743d..7531c5c12 100644 --- a/src/modules/m_banexception.cpp +++ b/src/modules/m_banexception.cpp @@ -79,7 +79,7 @@ public: for (modelist::iterator it = list->begin(); it != list->end(); it++) { - if (it->mask[0] != type || it->mask[1] != ':') + if (it->mask.length() <= 2 || it->mask[0] != type || it->mask[1] != ':') continue; if (chan->CheckBan(user, it->mask.substr(2))) |