summaryrefslogtreecommitdiff
path: root/src/modules/m_websocket.cpp
diff options
context:
space:
mode:
authorPeter Powell <petpow@saberuk.com>2018-10-10 16:45:35 +0100
committerPeter Powell <petpow@saberuk.com>2018-10-10 16:45:35 +0100
commit553877f7a9eff26166dfa4d953d6f69f9420de28 (patch)
tree657c30e461522f721613879b2bf4eae5d8b3a7f1 /src/modules/m_websocket.cpp
parent23090cb7e416cf5196bb79e8a99e43dfc2e56a4c (diff)
Require WebSocket origins to be whitelisted in order to connect.
Fixes #1281.
Diffstat (limited to 'src/modules/m_websocket.cpp')
-rw-r--r--src/modules/m_websocket.cpp52
1 files changed, 50 insertions, 2 deletions
diff --git a/src/modules/m_websocket.cpp b/src/modules/m_websocket.cpp
index 12102d215..5ac661ccf 100644
--- a/src/modules/m_websocket.cpp
+++ b/src/modules/m_websocket.cpp
@@ -21,6 +21,8 @@
#include "iohook.h"
#include "modules/hash.h"
+typedef std::vector<std::string> OriginList;
+
static const char MagicGUID[] = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
static const char whitespace[] = " \t\r\n";
static dynamic_reference_nocheck<HashProvider>* sha1;
@@ -28,6 +30,8 @@ static dynamic_reference_nocheck<HashProvider>* sha1;
class WebSocketHookProvider : public IOHookProvider
{
public:
+ OriginList allowedorigins;
+
WebSocketHookProvider(Module* mod)
: IOHookProvider(mod, "websocket", IOHookProvider::IOH_UNKNOWN, true)
{
@@ -101,6 +105,7 @@ class WebSocketHook : public IOHookMiddle
State state;
time_t lastpingpong;
+ OriginList& allowedorigins;
static size_t FillHeader(unsigned char* outbuf, size_t sendlength, OpCode opcode)
{
@@ -288,6 +293,27 @@ class WebSocketHook : public IOHookMiddle
if (reqend == std::string::npos)
return 0;
+ bool allowedorigin = false;
+ HTTPHeaderFinder originheader;
+ if (originheader.Find(recvq, "Origin:", 7, reqend))
+ {
+ const std::string origin = originheader.ExtractValue(recvq);
+ for (OriginList::const_iterator iter = allowedorigins.begin(); iter != allowedorigins.end(); ++iter)
+ {
+ if (InspIRCd::Match(origin, *iter, ascii_case_insensitive_map))
+ {
+ allowedorigin = true;
+ break;
+ }
+ }
+ }
+
+ if (!allowedorigin)
+ {
+ FailHandshake(sock, "HTTP/1.1 403 Forbidden\r\nConnection: close\r\n\r\n", "WebSocket: Received HTTP request from a non-whitelisted origin");
+ return -1;
+ }
+
HTTPHeaderFinder keyheader;
if (!keyheader.Find(recvq, "Sec-WebSocket-Key:", 18, reqend))
{
@@ -318,10 +344,11 @@ class WebSocketHook : public IOHookMiddle
}
public:
- WebSocketHook(IOHookProvider* Prov, StreamSocket* sock)
+ WebSocketHook(IOHookProvider* Prov, StreamSocket* sock, OriginList& AllowedOrigins)
: IOHookMiddle(Prov)
, state(STATE_HTTPREQ)
, lastpingpong(0)
+ , allowedorigins(AllowedOrigins)
{
sock->AddIOHook(this);
}
@@ -370,7 +397,7 @@ class WebSocketHook : public IOHookMiddle
void WebSocketHookProvider::OnAccept(StreamSocket* sock, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
{
- new WebSocketHook(this, sock);
+ new WebSocketHook(this, sock, allowedorigins);
}
class ModuleWebSocket : public Module
@@ -386,6 +413,27 @@ class ModuleWebSocket : public Module
sha1 = &hash;
}
+ void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
+ {
+ ConfigTagList tags = ServerInstance->Config->ConfTags("wsorigin");
+ if (tags.first == tags.second)
+ throw ModuleException("You have loaded the websocket module but not configured any allowed origins!");
+
+ OriginList allowedorigins;
+ for (ConfigIter i = tags.first; i != tags.second; ++i)
+ {
+ ConfigTag* tag = i->second;
+
+ // Ensure that we have the <wsorigin:allow> parameter.
+ const std::string allow = tag->getString("allow");
+ if (allow.empty())
+ throw ModuleException("<wsorigin:allow> is a mandatory field, at " + tag->getTagLocation());
+
+ allowedorigins.push_back(allow);
+ }
+ hookprov->allowedorigins.swap(allowedorigins);
+ }
+
void OnCleanup(ExtensionItem::ExtensibleType type, Extensible* item) CXX11_OVERRIDE
{
if (type != ExtensionItem::EXT_USER)