Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 4 insertions, 9 deletions

diff --git a/src/modules/m_auditorium.cpp b/src/modules/m_auditorium.cpp
index fa55d108e..19b37e245 100644
--- a/src/modules/m_auditorium.cpp
+++ b/src/modules/m_auditorium.cpp
@@ -37,19 +37,15 @@ class AuditoriumMode : public ModeHandler
 class ModuleAuditorium : public Module
 {
  private:
-	AuditoriumMode* aum;
+	AuditoriumMode aum;
 	bool ShowOps;
 	bool OperOverride;
  public:
 	ModuleAuditorium(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), aum(Me)
 	{
-		aum = new AuditoriumMode(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(aum))
-		{
-			delete aum;
+		if (!ServerInstance->Modes->AddMode(&aum))
 			throw ModuleException("Could not add new modes!");
-		}
 
 		OnRehash(NULL);
 
@@ -60,8 +56,7 @@ class ModuleAuditorium : public Module
 
 	virtual ~ModuleAuditorium()
 	{
-		ServerInstance->Modes->DelMode(aum);
-		delete aum;
+		ServerInstance->Modes->DelMode(&aum);
 	}
 
 	virtual void OnRehash(User* user)