summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorPeter Powell <petpow@saberuk.com>2018-12-16 01:26:04 +0000
committerPeter Powell <petpow@saberuk.com>2018-12-16 01:41:47 +0000
commit8ec9a73a91ad1c7009fd3055fbad7c980b5e1732 (patch)
tree659a24d10eecf040cfc25a25ac093a8b3a752d15 /include
parent0b36f9bdc8482284f0801a4a46b2525b32fa09a4 (diff)
Fix ParamModeBase::OnUnset() not being virtual.
Closes #1536.
Diffstat (limited to 'include')
-rw-r--r--include/parammode.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/include/parammode.h b/include/parammode.h
index b00082bd6..c79d11b6b 100644
--- a/include/parammode.h
+++ b/include/parammode.h
@@ -31,7 +31,7 @@ class CoreExport ParamModeBase : public ModeHandler
ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& param, bool adding) CXX11_OVERRIDE;
// Does nothing by default
- void OnUnset(User* source, Channel* chan) { }
+ virtual void OnUnset(User* source, Channel* chan) { }
virtual ModeAction OnSet(User* source, Channel* chan, std::string& param) = 0;
virtual void GetParameter(Channel* chan, std::string& out) = 0;
};
@@ -62,8 +62,7 @@ class ParamMode : public ParamModeBase
void OnUnsetInternal(User* source, Channel* chan) CXX11_OVERRIDE
{
- T* mh = static_cast<T*>(this);
- mh->OnUnset(source, chan);
+ this->OnUnset(source, chan);
ext.unset(chan);
}