diff options
author | Peter Powell <petpow@saberuk.com> | 2017-11-21 13:05:17 +0000 |
---|---|---|
committer | Peter Powell <petpow@saberuk.com> | 2017-11-21 15:51:45 +0000 |
commit | 91e0af0fc4889f20d2f63426f8fe379674fc0393 (patch) | |
tree | d3e39ed4c011b42054994e48a289eee51db9d879 | |
parent | 3013a9dfbf0c8c980dd59183c38a702e8179ee13 (diff) |
Add the override keyword in places that it is missing.
GCCs warnings for this are much better than Clangs.
130 files changed, 371 insertions, 373 deletions
diff --git a/include/builtinmodes.h b/include/builtinmodes.h index 49198b650..3bd3e2566 100644 --- a/include/builtinmodes.h +++ b/include/builtinmodes.h @@ -42,9 +42,9 @@ class ModeChannelKey : public ParamMode<ModeChannelKey, LocalStringExt> static const std::string::size_type maxkeylen = 32; public: ModeChannelKey(); - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding); - void SerializeParam(Channel* chan, const std::string* key, std::string& out); - ModeAction OnSet(User* source, Channel* chan, std::string& param); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE; + void SerializeParam(Channel* chan, const std::string* key, std::string& out) ; + ModeAction OnSet(User* source, Channel* chan, std::string& param) CXX11_OVERRIDE; }; /** Channel mode +l @@ -53,9 +53,9 @@ class ModeChannelLimit : public ParamMode<ModeChannelLimit, LocalIntExt> { public: ModeChannelLimit(); - bool ResolveModeConflict(std::string &their_param, const std::string &our_param, Channel* channel); + bool ResolveModeConflict(std::string& their_param, const std::string& our_param, Channel* channel) CXX11_OVERRIDE; void SerializeParam(Channel* chan, intptr_t n, std::string& out); - ModeAction OnSet(User* source, Channel* channel, std::string& parameter); + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE; }; /** Channel mode +o @@ -114,5 +114,5 @@ class ModeUserOperator : public ModeHandler { public: ModeUserOperator(); - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) CXX11_OVERRIDE; }; diff --git a/include/caller.h b/include/caller.h index 47f896ef6..dfa6ccebb 100644 --- a/include/caller.h +++ b/include/caller.h @@ -65,31 +65,31 @@ template<typename ReturnType, typename... Args> class CoreExport Caller #define caller8 Caller #define DEFINE_HANDLER0(NAME, RETURN) \ - class CoreExport NAME : public Handler<RETURN> { public: NAME() { } virtual RETURN Call(); } + class CoreExport NAME : public Handler<RETURN> { public: RETURN Call() CXX11_OVERRIDE; } #define DEFINE_HANDLER1(NAME, RETURN, V1) \ - class CoreExport NAME : public Handler<RETURN, V1> { public: NAME() { } virtual RETURN Call(V1); } + class CoreExport NAME : public Handler<RETURN, V1> { public: RETURN Call(V1) CXX11_OVERRIDE; } #define DEFINE_HANDLER2(NAME, RETURN, V1, V2) \ - class CoreExport NAME : public Handler<RETURN, V1, V2> { public: NAME() { } virtual RETURN Call(V1, V2); } + class CoreExport NAME : public Handler<RETURN, V1, V2> { public: RETURN Call(V1, V2) CXX11_OVERRIDE; } #define DEFINE_HANDLER3(NAME, RETURN, V1, V2, V3) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3> { public: NAME() { } virtual RETURN Call(V1, V2, V3); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3> { public: RETURN Call(V1, V2, V3) CXX11_OVERRIDE; } #define DEFINE_HANDLER4(NAME, RETURN, V1, V2, V3, V4) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4> { public: NAME() { } virtual RETURN Call(V1, V2, V3, V4); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4> { public: RETURN Call(V1, V2, V3, V4) CXX11_OVERRIDE; } #define DEFINE_HANDLER5(NAME, RETURN, V1, V2, V3, V4, V5) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5> { public: NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5> { public: RETURN Call(V1, V2, V3, V4, V5) CXX11_OVERRIDE; } #define DEFINE_HANDLER6(NAME, RETURN, V1, V2, V3, V4, V5, V6) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6> { public: NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6> { public: RETURN Call(V1, V2, V3, V4, V5, V6) CXX11_OVERRIDE; } #define DEFINE_HANDLER7(NAME, RETURN, V1, V2, V3, V4, V5, V6, V7) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6, V7> { public: NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6, V7> { public: RETURN Call(V1, V2, V3, V4, V5, V6, V7) CXX11_OVERRIDE; } #define DEFINE_HANDLER8(NAME, RETURN, V1, V2, V3, V4, V5, V6, V7, V8) \ - class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6, V7, V8> { public: NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7, V8); } + class CoreExport NAME : public Handler<RETURN, V1, V2, V3, V4, V5, V6, V7, V8> { public: RETURN Call(V1, V2, V3, V4, V5, V6, V7, V8) CXX11_OVERRIDE; } #else diff --git a/include/commands/cmd_whowas.h b/include/commands/cmd_whowas.h index 070858cc5..03ffae905 100644 --- a/include/commands/cmd_whowas.h +++ b/include/commands/cmd_whowas.h @@ -203,5 +203,5 @@ class CommandWhowas : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; diff --git a/include/configreader.h b/include/configreader.h index 69c98a55e..db7258d4e 100644 --- a/include/configreader.h +++ b/include/configreader.h @@ -516,7 +516,7 @@ class CoreExport ConfigReaderThread : public Thread delete Config; } - void Run(); + void Run() CXX11_OVERRIDE; /** Run in the main thread to apply the configuration */ void Finish(); bool IsDone() { return done; } diff --git a/include/ctables.h b/include/ctables.h index bba395919..43a311a66 100644 --- a/include/ctables.h +++ b/include/ctables.h @@ -236,7 +236,7 @@ class CoreExport SplitCommand : public Command public: SplitCommand(Module* me, const std::string &cmd, unsigned int minpara = 0, unsigned int maxpara = 0) : Command(me, cmd, minpara, maxpara) {} - virtual CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; virtual CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); virtual CmdResult HandleRemote(const std::vector<std::string>& parameters, RemoteUser* user); virtual CmdResult HandleServer(const std::vector<std::string>& parameters, FakeUser* user); diff --git a/include/extensible.h b/include/extensible.h index 1da45cee6..afb1cd5b6 100644 --- a/include/extensible.h +++ b/include/extensible.h @@ -111,7 +111,7 @@ class CoreExport Extensible : public classbase inline const ExtensibleStore& GetExtList() const { return extensions; } Extensible(); - virtual CullResult cull() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; virtual ~Extensible(); void doUnhookExtensions(const std::vector<reference<ExtensionItem> >& toRemove); @@ -145,9 +145,9 @@ class CoreExport LocalExtItem : public ExtensionItem public: LocalExtItem(const std::string& key, ExtensibleType exttype, Module* owner); virtual ~LocalExtItem(); - virtual std::string serialize(SerializeFormat format, const Extensible* container, void* item) const; - virtual void unserialize(SerializeFormat format, Extensible* container, const std::string& value); - virtual void free(void* item) = 0; + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE; + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; + void free(void* item) CXX11_OVERRIDE = 0; }; template <typename T, typename Del = stdalgo::defaultdeleter<T> > @@ -190,7 +190,7 @@ class SimpleExtItem : public LocalExtItem del(old); } - virtual void free(void* item) + void free(void* item) CXX11_OVERRIDE { Del del; del(static_cast<T*>(item)); @@ -202,8 +202,8 @@ class CoreExport LocalStringExt : public SimpleExtItem<std::string> public: LocalStringExt(const std::string& key, ExtensibleType exttype, Module* owner); virtual ~LocalStringExt(); - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const; - void unserialize(SerializeFormat format, Extensible* container, const std::string& value); + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE; + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; }; class CoreExport LocalIntExt : public LocalExtItem @@ -211,12 +211,12 @@ class CoreExport LocalIntExt : public LocalExtItem public: LocalIntExt(const std::string& key, ExtensibleType exttype, Module* owner); virtual ~LocalIntExt(); - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const; - void unserialize(SerializeFormat format, Extensible* container, const std::string& value); + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE; + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; intptr_t get(const Extensible* container) const; intptr_t set(Extensible* container, intptr_t value); void unset(Extensible* container) { set(container, 0); } - void free(void* item); + void free(void* item) CXX11_OVERRIDE; }; class CoreExport StringExtItem : public ExtensionItem @@ -225,9 +225,9 @@ class CoreExport StringExtItem : public ExtensionItem StringExtItem(const std::string& key, ExtensibleType exttype, Module* owner); virtual ~StringExtItem(); std::string* get(const Extensible* container) const; - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const; - void unserialize(SerializeFormat format, Extensible* container, const std::string& value); + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE; + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; void set(Extensible* container, const std::string& value); void unset(Extensible* container); - void free(void* item); + void free(void* item) CXX11_OVERRIDE; }; diff --git a/include/filelogger.h b/include/filelogger.h index ce571c3ae..af43a6d90 100644 --- a/include/filelogger.h +++ b/include/filelogger.h @@ -33,5 +33,5 @@ class CoreExport FileLogStream : public LogStream virtual ~FileLogStream(); - virtual void OnLog(LogLevel loglevel, const std::string &type, const std::string &msg); + void OnLog(LogLevel loglevel, const std::string& type, const std::string& msg) CXX11_OVERRIDE; }; diff --git a/include/inspircd.h b/include/inspircd.h index 5f5493350..47ec9e0e2 100644 --- a/include/inspircd.h +++ b/include/inspircd.h @@ -562,7 +562,7 @@ class CommandModule : public Module { } - Version GetVersion() + Version GetVersion() CXX11_OVERRIDE { return Version(cmd.name, VF_VENDOR|VF_CORE); } diff --git a/include/inspsocket.h b/include/inspsocket.h index 258d186b9..addb761d1 100644 --- a/include/inspsocket.h +++ b/include/inspsocket.h @@ -98,7 +98,7 @@ class CoreExport SocketTimeout : public Timer /** Handle tick event */ - virtual bool Tick(time_t now); + bool Tick(time_t now) CXX11_OVERRIDE; }; /** @@ -316,7 +316,7 @@ class CoreExport StreamSocket : public EventHandler */ virtual void Close(); /** This ensures that close is called prior to destructor */ - virtual CullResult cull() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; /** Get the IOHook of a module attached to this socket * @param mod Module whose IOHook to return @@ -376,7 +376,7 @@ class CoreExport BufferedSocket : public StreamSocket /** When there is data waiting to be read on a socket, the OnDataReady() * method is called. */ - virtual void OnDataReady() CXX11_OVERRIDE = 0; + void OnDataReady() CXX11_OVERRIDE = 0; /** * When an outbound connection fails, and the attempt times out, you diff --git a/include/listmode.h b/include/listmode.h index f978e9c9a..ba64f8b61 100644 --- a/include/listmode.h +++ b/include/listmode.h @@ -141,7 +141,7 @@ class CoreExport ListModeBase : public ModeHandler * @param user The user to send the list to * @param channel The channel the user is requesting the list for */ - virtual void DisplayList(User* user, Channel* channel); + void DisplayList(User* user, Channel* channel) CXX11_OVERRIDE; /** Tell a user that a list contains no elements. * Sends 'eolnum' numeric with text 'eolstr', unless overridden (see constructor) @@ -149,7 +149,7 @@ class CoreExport ListModeBase : public ModeHandler * @param channel The channel that has the empty list * See mode.h */ - virtual void DisplayEmptyList(User* user, Channel* channel); + void DisplayEmptyList(User* user, Channel* channel) CXX11_OVERRIDE; /** Remove all instances of the mode from a channel. * Populates the given modestack with modes that remove every instance of @@ -158,7 +158,7 @@ class CoreExport ListModeBase : public ModeHandler * @param channel The channel to remove all instances of the mode from * @param changelist Mode change list to populate with the removal of this mode */ - virtual void RemoveMode(Channel* channel, Modes::ChangeList& changelist); + void RemoveMode(Channel* channel, Modes::ChangeList& changelist) CXX11_OVERRIDE; /** Perform a rehash of this mode's configuration data */ @@ -167,7 +167,7 @@ class CoreExport ListModeBase : public ModeHandler /** Handle the list mode. * See mode.h */ - virtual ModeAction OnModeChange(User* source, User*, Channel* channel, std::string ¶meter, bool adding); + ModeAction OnModeChange(User* source, User*, Channel* channel, std::string ¶meter, bool adding) CXX11_OVERRIDE; /** Validate parameters. * Overridden by implementing module. diff --git a/include/mode.h b/include/mode.h index 83b8f31be..f944da62c 100644 --- a/include/mode.h +++ b/include/mode.h @@ -167,7 +167,7 @@ class CoreExport ModeHandler : public ServiceProvider * @param mclass The object type of this mode handler, one of ModeHandler::Class */ ModeHandler(Module* me, const std::string& name, char modeletter, ParamSpec params, ModeType type, Class mclass = MC_OTHER); - virtual CullResult cull() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; virtual ~ModeHandler(); /** Register this object in the ModeParser @@ -396,7 +396,7 @@ class CoreExport PrefixMode : public ModeHandler * The latter occurs either when the member cannot be found or when the member already has this prefix set * (when setting) or doesn't have this prefix set (when unsetting). */ - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& param, bool adding); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& param, bool adding) CXX11_OVERRIDE; /** * Updates the configuration of this prefix. @@ -412,7 +412,7 @@ class CoreExport PrefixMode : public ModeHandler * @param channel The channel which the server wants to remove your mode from * @param changelist Mode change list to populate with the removal of this mode */ - void RemoveMode(Channel* channel, Modes::ChangeList& changelist); + void RemoveMode(Channel* channel, Modes::ChangeList& changelist) CXX11_OVERRIDE; /** @@ -447,7 +447,7 @@ class CoreExport SimpleUserModeHandler : public ModeHandler public: SimpleUserModeHandler(Module* Creator, const std::string& Name, char modeletter) : ModeHandler(Creator, Name, modeletter, PARAM_NONE, MODETYPE_USER) {} - virtual ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE; }; /** A prebuilt mode handler which handles a simple channel mode, e.g. no parameters, usable by any user, with no extra @@ -460,7 +460,7 @@ class CoreExport SimpleChannelModeHandler : public ModeHandler public: SimpleChannelModeHandler(Module* Creator, const std::string& Name, char modeletter) : ModeHandler(Creator, Name, modeletter, PARAM_NONE, MODETYPE_CHANNEL) {} - virtual ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE; }; /** diff --git a/include/modules.h b/include/modules.h index 33b41e28f..ce2402964 100644 --- a/include/modules.h +++ b/include/modules.h @@ -286,7 +286,7 @@ class CoreExport Module : public classbase, public usecountbase /** Clean up prior to destruction * If you override, you must call this AFTER your module's cleanup */ - virtual CullResult cull() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; /** Default destructor. * destroys a module class diff --git a/include/modules/cap.h b/include/modules/cap.h index 86a60c445..8299d14ae 100644 --- a/include/modules/cap.h +++ b/include/modules/cap.h @@ -32,8 +32,8 @@ namespace Cap { public: ExtItem(Module* mod); - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const; - void unserialize(SerializeFormat format, Extensible* container, const std::string& value); + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE; + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; }; class Capability; diff --git a/include/modules/dns.h b/include/modules/dns.h index f3bf45916..3db651798 100644 --- a/include/modules/dns.h +++ b/include/modules/dns.h @@ -191,7 +191,7 @@ namespace DNS /** Used to time out the query, calls OnError and asks the TimerManager * to delete this request */ - bool Tick(time_t now) + bool Tick(time_t now) CXX11_OVERRIDE { Query rr(this->question); rr.error = ERROR_TIMEDOUT; diff --git a/include/threadengine.h b/include/threadengine.h index fec1bbb96..964b8d796 100644 --- a/include/threadengine.h +++ b/include/threadengine.h @@ -108,7 +108,7 @@ class CoreExport QueuedThread : public Thread queue.Wakeup(); queue.Unlock(); } - virtual void SetExitFlag() + void SetExitFlag() CXX11_OVERRIDE { queue.Lock(); Thread::SetExitFlag(); @@ -157,7 +157,7 @@ class CoreExport SocketThread : public Thread queue.Wakeup(); queue.Unlock(); } - virtual void SetExitFlag() + void SetExitFlag() CXX11_OVERRIDE { queue.Lock(); Thread::SetExitFlag(); diff --git a/include/users.h b/include/users.h index 40c99517d..12a311980 100644 --- a/include/users.h +++ b/include/users.h @@ -727,7 +727,7 @@ class CoreExport User : public Extensible /** Default destructor */ virtual ~User(); - virtual CullResult cull() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; }; class CoreExport UserIOHandler : public StreamSocket @@ -735,8 +735,8 @@ class CoreExport UserIOHandler : public StreamSocket public: LocalUser* const user; UserIOHandler(LocalUser* me) : user(me) {} - void OnDataReady(); - void OnError(BufferedSocketError error); + void OnDataReady() CXX11_OVERRIDE; + void OnError(BufferedSocketError error) CXX11_OVERRIDE; /** Adds to the user's write buffer. * You may add any amount of text up to this users sendq value, if you exceed the @@ -914,9 +914,9 @@ class CoreExport FakeUser : public User nick = sname; } - virtual CullResult cull() CXX11_OVERRIDE; - virtual const std::string& GetFullHost() CXX11_OVERRIDE; - virtual const std::string& GetFullRealHost() CXX11_OVERRIDE; + CullResult cull() CXX11_OVERRIDE; + const std::string& GetFullHost() CXX11_OVERRIDE; + const std::string& GetFullRealHost() CXX11_OVERRIDE; }; /* Faster than dynamic_cast */ diff --git a/include/xline.h b/include/xline.h index c2ede29df..9aae32b24 100644 --- a/include/xline.h +++ b/include/xline.h @@ -170,15 +170,15 @@ class CoreExport KLine : public XLine { } - virtual bool Matches(User *u); + bool Matches(User* u) CXX11_OVERRIDE; - virtual bool Matches(const std::string &str); + bool Matches(const std::string& str) CXX11_OVERRIDE; - virtual void Apply(User* u); + void Apply(User* u) CXX11_OVERRIDE; - virtual const std::string& Displayable(); + const std::string& Displayable() CXX11_OVERRIDE; - virtual bool IsBurstable(); + bool IsBurstable() CXX11_OVERRIDE; /** Ident mask (ident part only) */ @@ -216,13 +216,13 @@ class CoreExport GLine : public XLine { } - virtual bool Matches(User *u); + bool Matches(User* u) CXX11_OVERRIDE; - virtual bool Matches(const std::string &str); + bool Matches(const std::string& str) CXX11_OVERRIDE; - virtual void Apply(User* u); + void Apply(User* u) CXX11_OVERRIDE; - virtual const std::string& Displayable(); + const std::string& Displayable() CXX11_OVERRIDE; /** Ident mask (ident part only) */ @@ -258,15 +258,15 @@ class CoreExport ELine : public XLine { } - virtual bool Matches(User *u); + bool Matches(User* u) CXX11_OVERRIDE; - virtual bool Matches(const std::string &str); + bool Matches(const std::string& str) CXX11_OVERRIDE; - virtual void Unset(); + void Unset() CXX11_OVERRIDE; - virtual void OnAdd(); + void OnAdd() CXX11_OVERRIDE; - virtual const std::string& Displayable(); + const std::string& Displayable() CXX11_OVERRIDE; /** Ident mask (ident part only) */ @@ -301,13 +301,13 @@ class CoreExport ZLine : public XLine { } - virtual bool Matches(User *u); + bool Matches(User* u) CXX11_OVERRIDE; - virtual bool Matches(const std::string &str); + bool Matches(const std::string& str) CXX11_OVERRIDE; - virtual void Apply(User* u); + void Apply(User* u) CXX11_OVERRIDE; - virtual const std::string& Displayable(); + const std::string& Displayable() CXX11_OVERRIDE; /** IP mask (no ident part) */ @@ -336,13 +336,13 @@ class CoreExport QLine : public XLine ~QLine() { } - virtual bool Matches(User *u); + bool Matches(User* u) CXX11_OVERRIDE; - virtual bool Matches(const std::string &str); + bool Matches(const std::string& str) CXX11_OVERRIDE; - virtual void Apply(User* u); + void Apply(User* u) CXX11_OVERRIDE; - virtual const std::string& Displayable(); + const std::string& Displayable() CXX11_OVERRIDE; /** Nickname mask */ diff --git a/src/coremods/core_channel/core_channel.cpp b/src/coremods/core_channel/core_channel.cpp index 3af809645..045d94a1c 100644 --- a/src/coremods/core_channel/core_channel.cpp +++ b/src/coremods/core_channel/core_channel.cpp @@ -94,7 +94,7 @@ class CoreModChannel : public Module, public CheckExemption::EventListener } // Generate the MAXLIST token from the limits map. - std::string& buffer = tokens["MAXLIST"]; + std::string& buffer = tokens["MAX LIST"]; for (insp::flat_map<int, std::string>::const_iterator iter = limits.begin(); iter != limits.end(); ++iter) { if (!buffer.empty()) diff --git a/src/coremods/core_channel/core_channel.h b/src/coremods/core_channel/core_channel.h index 19a984827..46def3e7b 100644 --- a/src/coremods/core_channel/core_channel.h +++ b/src/coremods/core_channel/core_channel.h @@ -48,8 +48,8 @@ class CommandInvite : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User*user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; /** Handle /JOIN. @@ -66,7 +66,7 @@ class CommandJoin : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; }; /** Handle /TOPIC. @@ -87,7 +87,7 @@ class CommandTopic : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; }; /** Handle /NAMES. @@ -108,7 +108,7 @@ class CommandNames : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; /** Spool the NAMES list for a given channel to the given user * @param user User to spool the NAMES list to @@ -132,6 +132,6 @@ class CommandKick : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; diff --git a/src/coremods/core_hostname_lookup.cpp b/src/coremods/core_hostname_lookup.cpp index 4ec88698e..4320b1e57 100644 --- a/src/coremods/core_hostname_lookup.cpp +++ b/src/coremods/core_hostname_lookup.cpp @@ -56,7 +56,7 @@ class UserResolver : public DNS::Request * if a previous result has already come back. * @param r The finished query */ - void OnLookupComplete(const DNS::Query* r) + void OnLookupComplete(const DNS::Query* r) CXX11_OVERRIDE { LocalUser* bound_user = (LocalUser*)ServerInstance->FindUUID(uuid); if (!bound_user) @@ -164,7 +164,7 @@ class UserResolver : public DNS::Request /** Called on failed lookup * @param query The errored query */ - void OnError(const DNS::Query* query) + void OnError(const DNS::Query* query) CXX11_OVERRIDE { LocalUser* bound_user = (LocalUser*)ServerInstance->FindUUID(uuid); if (bound_user) diff --git a/src/coremods/core_info/core_info.h b/src/coremods/core_info/core_info.h index ecfeb4f36..53b949ac5 100644 --- a/src/coremods/core_info/core_info.h +++ b/src/coremods/core_info/core_info.h @@ -31,7 +31,7 @@ class ServerTargetCommand : public Command { } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; /** Handle /ADMIN. @@ -63,7 +63,7 @@ class CommandAdmin : public ServerTargetCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /COMMANDS. @@ -80,7 +80,7 @@ class CommandCommands : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /INFO. @@ -97,7 +97,7 @@ class CommandInfo : public ServerTargetCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /MODULES. @@ -114,7 +114,7 @@ class CommandModules : public ServerTargetCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /MOTD. @@ -131,7 +131,7 @@ class CommandMotd : public ServerTargetCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /TIME. @@ -148,7 +148,7 @@ class CommandTime : public ServerTargetCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /VERSION. @@ -165,5 +165,5 @@ class CommandVersion : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; diff --git a/src/coremods/core_ison.cpp b/src/coremods/core_ison.cpp index f1733ba88..642e36b43 100644 --- a/src/coremods/core_ison.cpp +++ b/src/coremods/core_ison.cpp @@ -37,7 +37,7 @@ class CommandIson : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; }; class IsonReplyBuilder : public Numeric::Builder<' ', true> diff --git a/src/coremods/core_list.cpp b/src/coremods/core_list.cpp index 910ebb987..600ec47c2 100644 --- a/src/coremods/core_list.cpp +++ b/src/coremods/core_list.cpp @@ -56,7 +56,7 @@ class CommandList : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; diff --git a/src/coremods/core_loadmodule.cpp b/src/coremods/core_loadmodule.cpp index fde149587..1064da6c8 100644 --- a/src/coremods/core_loadmodule.cpp +++ b/src/coremods/core_loadmodule.cpp @@ -33,7 +33,7 @@ class CommandLoadmodule : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /LOADMODULE @@ -72,7 +72,7 @@ class CommandUnloadmodule : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; CmdResult CommandUnloadmodule::Handle(const std::vector<std::string>& parameters, User* user) diff --git a/src/coremods/core_lusers.cpp b/src/coremods/core_lusers.cpp index 7f1903dd0..a995e59e7 100644 --- a/src/coremods/core_lusers.cpp +++ b/src/coremods/core_lusers.cpp @@ -61,7 +61,7 @@ class CommandLusers : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /LUSERS @@ -110,7 +110,7 @@ public: { } - void AfterMode(User* source, User* dest, Channel* channel, const std::string& parameter, bool adding) + void AfterMode(User* source, User* dest, Channel* channel, const std::string& parameter, bool adding) CXX11_OVERRIDE { if (dest->registered != REG_ALL) return; diff --git a/src/coremods/core_oper/core_oper.h b/src/coremods/core_oper/core_oper.h index 619fdf1fa..be615239e 100644 --- a/src/coremods/core_oper/core_oper.h +++ b/src/coremods/core_oper/core_oper.h @@ -51,7 +51,7 @@ class CommandDie : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /KILL. @@ -71,10 +71,10 @@ class CommandKill : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; - void EncodeParameter(std::string& param, unsigned int index); + void EncodeParameter(std::string& param, unsigned int index) CXX11_OVERRIDE; }; /** Handle /OPER. @@ -91,7 +91,7 @@ class CommandOper : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; }; /** Handle /REHASH. @@ -108,7 +108,7 @@ class CommandRehash : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /RESTART @@ -125,5 +125,5 @@ class CommandRestart : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; diff --git a/src/coremods/core_privmsg.cpp b/src/coremods/core_privmsg.cpp index 449097a75..d19ae09b5 100644 --- a/src/coremods/core_privmsg.cpp +++ b/src/coremods/core_privmsg.cpp @@ -54,7 +54,7 @@ class MessageCommandBase : public Command */ CmdResult HandleMessage(const std::vector<std::string>& parameters, User* user, MessageType mt); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if (IS_LOCAL(user)) // This is handled by the OnUserMessage hook to split the LoopCall pieces @@ -263,7 +263,7 @@ class CommandMessage : public MessageCommandBase { } - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { return HandleMessage(parameters, user, MT); } diff --git a/src/coremods/core_reloadmodule.cpp b/src/coremods/core_reloadmodule.cpp index ffd4f9bf5..9684c8c13 100644 --- a/src/coremods/core_reloadmodule.cpp +++ b/src/coremods/core_reloadmodule.cpp @@ -45,7 +45,7 @@ class CommandReloadmodule : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; namespace ReloadModule @@ -579,7 +579,7 @@ class ReloadAction : public HandlerBase0<void> { } - void Call() + void Call() CXX11_OVERRIDE { ReloadModule::DataKeeper datakeeper; datakeeper.Save(mod); diff --git a/src/coremods/core_stats.cpp b/src/coremods/core_stats.cpp index 7c3484917..ef6a12d34 100644 --- a/src/coremods/core_stats.cpp +++ b/src/coremods/core_stats.cpp @@ -41,8 +41,8 @@ class CommandStats : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if ((parameters.size() > 1) && (parameters[1].find('.') != std::string::npos)) return ROUTE_UNICAST(parameters[1]); diff --git a/src/coremods/core_stub.cpp b/src/coremods/core_stub.cpp index 71b0ddaea..6adc02f32 100644 --- a/src/coremods/core_stub.cpp +++ b/src/coremods/core_stub.cpp @@ -41,7 +41,7 @@ class CommandConnect : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* * This is handled by the server linking module, if necessary. Do not remove this stub. @@ -68,7 +68,7 @@ class CommandLinks : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { user->WriteNumeric(RPL_LINKS, ServerInstance->Config->ServerName, ServerInstance->Config->ServerName, InspIRCd::Format("0 %s", ServerInstance->Config->ServerDesc.c_str())); user->WriteNumeric(RPL_ENDOFLINKS, '*', "End of /LINKS list."); @@ -94,7 +94,7 @@ class CommandServer : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (user->registered == REG_ALL) { @@ -127,7 +127,7 @@ class CommandSquit : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { user->WriteNotice("Look into loading a linking module (like m_spanningtree) if you want this to do anything useful."); return CMD_FAILURE; diff --git a/src/coremods/core_user/core_user.cpp b/src/coremods/core_user/core_user.cpp index a2ffc009e..5068bd4aa 100644 --- a/src/coremods/core_user/core_user.cpp +++ b/src/coremods/core_user/core_user.cpp @@ -40,7 +40,7 @@ class CommandPass : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser *user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { // Check to make sure they haven't registered -- Fix by FCS if (user->registered == REG_ALL) @@ -73,7 +73,7 @@ class CommandPing : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { user->WriteServ("PONG %s :%s", ServerInstance->Config->ServerName.c_str(), parameters[0].c_str()); return CMD_SUCCESS; @@ -99,7 +99,7 @@ class CommandPong : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { // set the user as alive so they survive to next ping LocalUser* localuser = IS_LOCAL(user); diff --git a/src/coremods/core_user/core_user.h b/src/coremods/core_user/core_user.h index 72ba67869..2a1ba7bfd 100644 --- a/src/coremods/core_user/core_user.h +++ b/src/coremods/core_user/core_user.h @@ -58,8 +58,8 @@ class CommandAway : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandMode : public Command @@ -91,9 +91,9 @@ class CommandMode : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; /** Handle /NICK. @@ -110,7 +110,7 @@ class CommandNick : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; }; /** Handle /PART. @@ -129,8 +129,8 @@ class CommandPart : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; /** Handle /QUIT. @@ -152,9 +152,9 @@ class CommandQuit : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User*user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; /** Handle /USER. @@ -171,7 +171,7 @@ class CommandUser : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser *user); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; /** Run the OnUserRegister hook if the user has sent both NICK and USER. Called after an unregistered user * successfully executes the USER or the NICK command. diff --git a/src/coremods/core_userhost.cpp b/src/coremods/core_userhost.cpp index 7ee093cdb..2ed19f4d7 100644 --- a/src/coremods/core_userhost.cpp +++ b/src/coremods/core_userhost.cpp @@ -40,7 +40,7 @@ class CommandUserhost : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; CmdResult CommandUserhost::Handle (const std::vector<std::string>& parameters, User *user) diff --git a/src/coremods/core_wallops.cpp b/src/coremods/core_wallops.cpp index 0210df8ee..d45ede846 100644 --- a/src/coremods/core_wallops.cpp +++ b/src/coremods/core_wallops.cpp @@ -42,9 +42,9 @@ class CommandWallops : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/coremods/core_who.cpp b/src/coremods/core_who.cpp index ba1883e77..5a3db9f83 100644 --- a/src/coremods/core_who.cpp +++ b/src/coremods/core_who.cpp @@ -74,7 +74,7 @@ class CommandWho : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; bool whomatch(User* cuser, User* user, const char* matchtext); }; diff --git a/src/coremods/core_whois.cpp b/src/coremods/core_whois.cpp index d726b6b6c..1dd087e12 100644 --- a/src/coremods/core_whois.cpp +++ b/src/coremods/core_whois.cpp @@ -78,8 +78,8 @@ class CommandWhois : public SplitCommand * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user); - CmdResult HandleRemote(const std::vector<std::string>& parameters, RemoteUser* target); + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE; + CmdResult HandleRemote(const std::vector<std::string>& parameters, RemoteUser* target) CXX11_OVERRIDE; }; class WhoisNumericSink diff --git a/src/coremods/core_xline/core_xline.h b/src/coremods/core_xline/core_xline.h index 5b34e7a4d..11756c06b 100644 --- a/src/coremods/core_xline/core_xline.h +++ b/src/coremods/core_xline/core_xline.h @@ -34,7 +34,7 @@ class InsaneBan class Matcher : public MatcherBase { public: - long Run(const std::string& mask) + long Run(const std::string& mask) CXX11_OVERRIDE { long matches = 0; const T* c = static_cast<T*>(this); @@ -79,7 +79,7 @@ class CommandEline : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /GLINE. @@ -96,7 +96,7 @@ class CommandGline : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /KLINE. @@ -113,7 +113,7 @@ class CommandKline : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /QLINE. @@ -136,7 +136,7 @@ class CommandQline : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; /** Handle /ZLINE. @@ -159,5 +159,5 @@ class CommandZline : public Command * @param user The user issuing the command * @return A value from CmdResult to indicate command success or failure. */ - CmdResult Handle(const std::vector<std::string>& parameters, User* user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; diff --git a/src/modules.cpp b/src/modules.cpp index 065f12a1f..9a3618264 100644 --- a/src/modules.cpp +++ b/src/modules.cpp @@ -444,7 +444,7 @@ namespace { Module* const mod; UnloadAction(Module* m) : mod(m) {} - void Call() + void Call() CXX11_OVERRIDE { DLLManager* dll = mod->ModuleDLLManager; ServerInstance->Modules->DoSafeUnload(mod); diff --git a/src/modules/extra/m_mysql.cpp b/src/modules/extra/m_mysql.cpp index 3490f7fa6..aa396d55f 100644 --- a/src/modules/extra/m_mysql.cpp +++ b/src/modules/extra/m_mysql.cpp @@ -126,8 +126,8 @@ class DispatcherThread : public SocketThread public: DispatcherThread(ModuleSQL* CreatorModule) : Parent(CreatorModule) { } ~DispatcherThread() { } - void Run(); - void OnNotify(); + void Run() CXX11_OVERRIDE; + void OnNotify() CXX11_OVERRIDE; }; #if !defined(MYSQL_VERSION_ID) || MYSQL_VERSION_ID<32224 @@ -193,12 +193,12 @@ class MySQLresult : public SQLResult } - int Rows() + int Rows() CXX11_OVERRIDE { return rows; } - void GetCols(std::vector<std::string>& result) + void GetCols(std::vector<std::string>& result) CXX11_OVERRIDE { result.assign(colnames.begin(), colnames.end()); } @@ -212,7 +212,7 @@ class MySQLresult : public SQLResult return SQLEntry(); } - bool GetRow(SQLEntries& result) + bool GetRow(SQLEntries& result) CXX11_OVERRIDE { if (currentrow < rows) { @@ -319,14 +319,14 @@ class SQLConnection : public SQLProvider mysql_close(connection); } - void submit(SQLQuery* q, const std::string& qs) + void submit(SQLQuery* q, const std::string& qs) CXX11_OVERRIDE { Parent()->Dispatcher->LockQueue(); Parent()->qq.push_back(QQueueItem(q, qs, this)); Parent()->Dispatcher->UnlockQueueWakeup(); } - void submit(SQLQuery* call, const std::string& q, const ParamL& p) + void submit(SQLQuery* call, const std::string& q, const ParamL& p) CXX11_OVERRIDE { std::string res; unsigned int param = 0; @@ -354,7 +354,7 @@ class SQLConnection : public SQLProvider submit(call, res); } - void submit(SQLQuery* call, const std::string& q, const ParamM& p) + void submit(SQLQuery* call, const std::string& q, const ParamM& p) CXX11_OVERRIDE { std::string res; for(std::string::size_type i = 0; i < q.length(); i++) diff --git a/src/modules/extra/m_pgsql.cpp b/src/modules/extra/m_pgsql.cpp index 09aba7de9..7aaf96a67 100644 --- a/src/modules/extra/m_pgsql.cpp +++ b/src/modules/extra/m_pgsql.cpp @@ -65,7 +65,7 @@ class ReconnectTimer : public Timer ReconnectTimer(ModulePgSQL* m) : Timer(5, false), mod(m) { } - bool Tick(time_t TIME); + bool Tick(time_t TIME) CXX11_OVERRIDE; }; struct QueueItem @@ -100,12 +100,12 @@ class PgSQLresult : public SQLResult PQclear(res); } - int Rows() + int Rows() CXX11_OVERRIDE { return rows; } - void GetCols(std::vector<std::string>& result) + void GetCols(std::vector<std::string>& result) CXX11_OVERRIDE { result.resize(PQnfields(res)); for(unsigned int i=0; i < result.size(); i++) @@ -123,7 +123,7 @@ class PgSQLresult : public SQLResult return SQLEntry(std::string(v, PQgetlength(res, row, column))); } - bool GetRow(SQLEntries& result) + bool GetRow(SQLEntries& result) CXX11_OVERRIDE { if (currentrow >= PQntuples(res)) return false; diff --git a/src/modules/extra/m_sqlite3.cpp b/src/modules/extra/m_sqlite3.cpp index c7af2c23a..5f6cd1ce3 100644 --- a/src/modules/extra/m_sqlite3.cpp +++ b/src/modules/extra/m_sqlite3.cpp @@ -58,12 +58,12 @@ class SQLite3Result : public SQLResult { } - int Rows() + int Rows() CXX11_OVERRIDE { return rows; } - bool GetRow(SQLEntries& result) + bool GetRow(SQLEntries& result) CXX11_OVERRIDE { if (currentrow < rows) { @@ -78,7 +78,7 @@ class SQLite3Result : public SQLResult } } - void GetCols(std::vector<std::string>& result) + void GetCols(std::vector<std::string>& result) CXX11_OVERRIDE { result.assign(columns.begin(), columns.end()); } @@ -159,13 +159,13 @@ class SQLConn : public SQLProvider sqlite3_finalize(stmt); } - void submit(SQLQuery* query, const std::string& q) + void submit(SQLQuery* query, const std::string& q) CXX11_OVERRIDE { Query(query, q); delete query; } - void submit(SQLQuery* query, const std::string& q, const ParamL& p) + void submit(SQLQuery* query, const std::string& q, const ParamL& p) CXX11_OVERRIDE { std::string res; unsigned int param = 0; @@ -186,7 +186,7 @@ class SQLConn : public SQLProvider submit(query, res); } - void submit(SQLQuery* query, const std::string& q, const ParamM& p) + void submit(SQLQuery* query, const std::string& q, const ParamM& p) CXX11_OVERRIDE { std::string res; for(std::string::size_type i = 0; i < q.length(); i++) diff --git a/src/modules/extra/m_ssl_gnutls.cpp b/src/modules/extra/m_ssl_gnutls.cpp index 534c3abbc..2d278c967 100644 --- a/src/modules/extra/m_ssl_gnutls.cpp +++ b/src/modules/extra/m_ssl_gnutls.cpp @@ -115,7 +115,7 @@ static Module* thismod; class RandGen : public HandlerBase2<void, char*, size_t> { public: - void Call(char* buffer, size_t len) + void Call(char* buffer, size_t len) CXX11_OVERRIDE { #ifdef GNUTLS_HAS_RND gnutls_rnd(GNUTLS_RND_RANDOM, buffer, len); diff --git a/src/modules/m_alltime.cpp b/src/modules/m_alltime.cpp index 73c0fa994..de3e702ac 100644 --- a/src/modules/m_alltime.cpp +++ b/src/modules/m_alltime.cpp @@ -29,7 +29,7 @@ class CommandAlltime : public Command flags_needed = 'o'; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { const std::string fmtdate = InspIRCd::TimeString(ServerInstance->Time(), "%Y-%m-%d %H:%M:%S", true); @@ -41,7 +41,7 @@ class CommandAlltime : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_BCAST; } diff --git a/src/modules/m_autoop.cpp b/src/modules/m_autoop.cpp index 257c3647c..3eab189f2 100644 --- a/src/modules/m_autoop.cpp +++ b/src/modules/m_autoop.cpp @@ -41,7 +41,7 @@ class AutoOpList : public ListModeBase return mh ? mh->IsPrefixMode() : NULL; } - ModResult AccessCheck(User* source, Channel* channel, std::string ¶meter, bool adding) + ModResult AccessCheck(User* source, Channel* channel, std::string ¶meter, bool adding) CXX11_OVERRIDE { std::string::size_type pos = parameter.find(':'); if (pos == 0 || pos == std::string::npos) diff --git a/src/modules/m_banredirect.cpp b/src/modules/m_banredirect.cpp index 4c5d53d35..4a4188757 100644 --- a/src/modules/m_banredirect.cpp +++ b/src/modules/m_banredirect.cpp @@ -54,7 +54,7 @@ class BanRedirect : public ModeWatcher { } - bool BeforeMode(User* source, User* dest, Channel* channel, std::string ¶m, bool adding) + bool BeforeMode(User* source, User* dest, Channel* channel, std::string& param, bool adding) CXX11_OVERRIDE { /* nick!ident@host -> nick!ident@host * nick!ident@host#chan -> nick!ident@host#chan diff --git a/src/modules/m_callerid.cpp b/src/modules/m_callerid.cpp index 74334cd24..137ab6b93 100644 --- a/src/modules/m_callerid.cpp +++ b/src/modules/m_callerid.cpp @@ -73,7 +73,7 @@ struct CallerIDExtInfo : public ExtensionItem { } - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE { std::string ret; if (format != FORMAT_NETWORK) @@ -84,7 +84,7 @@ struct CallerIDExtInfo : public ExtensionItem return ret; } - void unserialize(SerializeFormat format, Extensible* container, const std::string& value) + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE { if (format == FORMAT_NETWORK) return; @@ -125,7 +125,7 @@ struct CallerIDExtInfo : public ExtensionItem return dat; } - void free(void* item) + void free(void* item) CXX11_OVERRIDE { callerid_data* dat = static_cast<callerid_data*>(item); @@ -182,7 +182,7 @@ public: TRANSLATE1(TR_CUSTOM); } - void EncodeParameter(std::string& parameter, unsigned int index) + void EncodeParameter(std::string& parameter, unsigned int index) CXX11_OVERRIDE { // Send lists as-is (part of 2.0 compat) if (parameter.find(',') != std::string::npos) @@ -201,7 +201,7 @@ public: * /accept nick1,nick2,nick3,* * to add 3 nicks and then show your list */ - CmdResult Handle(const std::vector<std::string> ¶meters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (CommandParser::LoopCall(user, this, parameters, 0)) return CMD_SUCCESS; @@ -234,7 +234,7 @@ public: return (RemoveAccept(user, action.first) ? CMD_SUCCESS : CMD_FAILURE); } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { // There is a list in parameters[0] in two cases: // Either when the source is remote, this happens because 2.0 servers send comma seperated uuid lists, diff --git a/src/modules/m_cban.cpp b/src/modules/m_cban.cpp index 42cff2850..54b1e39ee 100644 --- a/src/modules/m_cban.cpp +++ b/src/modules/m_cban.cpp @@ -38,17 +38,17 @@ public: } // XXX I shouldn't have to define this - bool Matches(User *u) + bool Matches(User* u) CXX11_OVERRIDE { return false; } - bool Matches(const std::string &s) + bool Matches(const std::string& s) CXX11_OVERRIDE { return irc::equals(matchtext, s); } - const std::string& Displayable() + const std::string& Displayable() CXX11_OVERRIDE { return matchtext; } @@ -63,12 +63,12 @@ class CBanFactory : public XLineFactory /** Generate a CBAN */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { return new CBan(set_time, duration, source, reason, xline_specific_mask); } - bool AutoApplyToUserList(XLine *x) + bool AutoApplyToUserList(XLine* x) CXX11_OVERRIDE { return false; // No, we apply to channels. } @@ -84,7 +84,7 @@ class CommandCBan : public Command flags_needed = 'o'; this->syntax = "<channel> [<duration> :<reason>]"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* syntax: CBAN #channel time :reason goes here */ /* 'time' is a human-readable timestring, like 2d3h2s. */ @@ -131,7 +131,7 @@ class CommandCBan : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if (IS_LOCAL(user)) return ROUTE_LOCALONLY; // spanningtree will send ADDLINE diff --git a/src/modules/m_chanfilter.cpp b/src/modules/m_chanfilter.cpp index 90e266fc3..133c5180d 100644 --- a/src/modules/m_chanfilter.cpp +++ b/src/modules/m_chanfilter.cpp @@ -34,8 +34,7 @@ class ChanFilter : public ListModeBase public: ChanFilter(Module* Creator) : ListModeBase(Creator, "filter", 'g', "End of channel spamfilter list", 941, 940, false, "chanfilter") { } - bool ValidateParam(User* user, Channel* chan, std::string &word) - { + bool ValidateParam(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { if (word.length() > 35) { user->WriteNumeric(935, chan->name, word, "%word is too long for censor list"); @@ -45,17 +44,17 @@ class ChanFilter : public ListModeBase return true; } - void TellListTooLong(User* user, Channel* chan, std::string &word) + void TellListTooLong(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(939, chan->name, word, "Channel spamfilter list is full"); } - void TellAlreadyOnList(User* user, Channel* chan, std::string &word) + void TellAlreadyOnList(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(937, chan->name, InspIRCd::Format("The word %s is already on the spamfilter list", word.c_str())); } - void TellNotSet(User* user, Channel* chan, std::string &word) + void TellNotSet(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(938, chan->name, "No such spamfilter word is set"); } diff --git a/src/modules/m_chanhistory.cpp b/src/modules/m_chanhistory.cpp index a969ab2e2..4ed1ae6ae 100644 --- a/src/modules/m_chanhistory.cpp +++ b/src/modules/m_chanhistory.cpp @@ -59,7 +59,7 @@ class HistoryMode : public ParamMode<HistoryMode, SimpleExtItem<HistoryList> > { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { std::string::size_type colon = parameter.find(':'); if (colon == std::string::npos) diff --git a/src/modules/m_channames.cpp b/src/modules/m_channames.cpp index 7513cb33a..b23148b44 100644 --- a/src/modules/m_channames.cpp +++ b/src/modules/m_channames.cpp @@ -24,7 +24,7 @@ static std::bitset<256> allowedmap; class NewIsChannelHandler : public HandlerBase1<bool, const std::string&> { public: - bool Call(const std::string&); + bool Call(const std::string&) CXX11_OVERRIDE; }; bool NewIsChannelHandler::Call(const std::string& channame) diff --git a/src/modules/m_check.cpp b/src/modules/m_check.cpp index e401c79f1..f2da47f1b 100644 --- a/src/modules/m_check.cpp +++ b/src/modules/m_check.cpp @@ -140,7 +140,7 @@ class CommandCheck : public Command return ret; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters.size() > 1 && parameters[1] != ServerInstance->Config->ServerName) return CMD_SUCCESS; @@ -301,7 +301,7 @@ class CommandCheck : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if ((parameters.size() > 1) && (parameters[1].find('.') != std::string::npos)) return ROUTE_OPT_UCAST(parameters[1]); diff --git a/src/modules/m_chghost.cpp b/src/modules/m_chghost.cpp index 8b588b63d..30efd1390 100644 --- a/src/modules/m_chghost.cpp +++ b/src/modules/m_chghost.cpp @@ -35,7 +35,7 @@ class CommandChghost : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters[1].length() > ServerInstance->Config->Limits.MaxHost) { @@ -73,7 +73,7 @@ class CommandChghost : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_chgident.cpp b/src/modules/m_chgident.cpp index 8ba5b4a5b..f09bef0ab 100644 --- a/src/modules/m_chgident.cpp +++ b/src/modules/m_chgident.cpp @@ -35,7 +35,7 @@ class CommandChgident : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); @@ -68,7 +68,7 @@ class CommandChgident : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_chgname.cpp b/src/modules/m_chgname.cpp index 2582ef652..46894befc 100644 --- a/src/modules/m_chgname.cpp +++ b/src/modules/m_chgname.cpp @@ -33,7 +33,7 @@ class CommandChgname : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); @@ -64,7 +64,7 @@ class CommandChgname : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_clearchan.cpp b/src/modules/m_clearchan.cpp index 08a7a88b5..0c6d52265 100644 --- a/src/modules/m_clearchan.cpp +++ b/src/modules/m_clearchan.cpp @@ -35,7 +35,7 @@ class CommandClearChan : public Command force_manual_route = true; } - CmdResult Handle(const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { Channel* chan = activechan = ServerInstance->FindChan(parameters[0]); if (!chan) diff --git a/src/modules/m_cloaking.cpp b/src/modules/m_cloaking.cpp index 1cfd9516c..a1e4d1af7 100644 --- a/src/modules/m_cloaking.cpp +++ b/src/modules/m_cloaking.cpp @@ -53,7 +53,7 @@ class CloakUser : public ModeHandler { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { LocalUser* user = IS_LOCAL(dest); @@ -131,7 +131,7 @@ class CommandCloak : public Command syntax = "<host>"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; }; class ModuleCloaking : public Module diff --git a/src/modules/m_clones.cpp b/src/modules/m_clones.cpp index 3084b32a8..7cce32188 100644 --- a/src/modules/m_clones.cpp +++ b/src/modules/m_clones.cpp @@ -31,7 +31,7 @@ class CommandClones : public Command flags_needed = 'o'; syntax = "<limit>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { std::string clonesstr = "CLONES "; diff --git a/src/modules/m_close.cpp b/src/modules/m_close.cpp index 3f0eedaaf..8ef93830d 100644 --- a/src/modules/m_close.cpp +++ b/src/modules/m_close.cpp @@ -31,7 +31,7 @@ class CommandClose : public Command flags_needed = 'o'; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *src) + CmdResult Handle(const std::vector<std::string>& parameters, User* src) CXX11_OVERRIDE { std::map<std::string,int> closed; diff --git a/src/modules/m_customtitle.cpp b/src/modules/m_customtitle.cpp index 2a08592ea..16d1ae738 100644 --- a/src/modules/m_customtitle.cpp +++ b/src/modules/m_customtitle.cpp @@ -33,7 +33,7 @@ class CommandTitle : public Command syntax = "<user> <password>"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { const std::string userHost = user->ident + "@" + user->GetRealHost(); const std::string userIP = user->ident + "@" + user->GetIPString(); diff --git a/src/modules/m_cycle.cpp b/src/modules/m_cycle.cpp index 202cb123f..68463a4e7 100644 --- a/src/modules/m_cycle.cpp +++ b/src/modules/m_cycle.cpp @@ -31,7 +31,7 @@ class CommandCycle : public SplitCommand Penalty = 3; syntax = "<channel> :[reason]"; } - CmdResult HandleLocal(const std::vector<std::string> ¶meters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { Channel* channel = ServerInstance->FindChan(parameters[0]); std::string reason = "Cycling"; diff --git a/src/modules/m_dccallow.cpp b/src/modules/m_dccallow.cpp index 12955d709..18ec87179 100644 --- a/src/modules/m_dccallow.cpp +++ b/src/modules/m_dccallow.cpp @@ -96,7 +96,7 @@ class CommandDccallow : public Command /* XXX we need to fix this so it can work with translation stuff (i.e. move +- into a seperate param */ } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* syntax: DCCALLOW [+|-]<nick> (<time>) */ if (!parameters.size()) @@ -234,7 +234,7 @@ class CommandDccallow : public Command return CMD_FAILURE; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/modules/m_deaf.cpp b/src/modules/m_deaf.cpp index 88919e91b..7cad49d76 100644 --- a/src/modules/m_deaf.cpp +++ b/src/modules/m_deaf.cpp @@ -28,7 +28,7 @@ class User_d : public ModeHandler public: User_d(Module* Creator) : ModeHandler(Creator, "deaf", 'd', PARAM_NONE, MODETYPE_USER) { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { if (adding == dest->IsModeSet(this)) return MODEACTION_DENY; diff --git a/src/modules/m_delayjoin.cpp b/src/modules/m_delayjoin.cpp index 6d1251345..d26a56568 100644 --- a/src/modules/m_delayjoin.cpp +++ b/src/modules/m_delayjoin.cpp @@ -31,7 +31,7 @@ class DelayJoinMode : public ModeHandler ranktoset = ranktounset = OP_VALUE; } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding); + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE; }; class ModuleDelayJoin : public Module diff --git a/src/modules/m_delaymsg.cpp b/src/modules/m_delaymsg.cpp index 3471c7fd2..247630e65 100644 --- a/src/modules/m_delaymsg.cpp +++ b/src/modules/m_delaymsg.cpp @@ -30,12 +30,12 @@ class DelayMsgMode : public ParamMode<DelayMsgMode, LocalIntExt> ranktoset = ranktounset = OP_VALUE; } - bool ResolveModeConflict(std::string &their_param, const std::string &our_param, Channel*) + bool ResolveModeConflict(std::string& their_param, const std::string& our_param, Channel*) CXX11_OVERRIDE { return (atoi(their_param.c_str()) < atoi(our_param.c_str())); } - ModeAction OnSet(User* source, Channel* chan, std::string& parameter); + ModeAction OnSet(User* source, Channel* chan, std::string& parameter) CXX11_OVERRIDE; void OnUnset(User* source, Channel* chan); void SerializeParam(Channel* chan, int n, std::string& out) diff --git a/src/modules/m_exemptchanops.cpp b/src/modules/m_exemptchanops.cpp index 0c67037f0..52e7c4dad 100644 --- a/src/modules/m_exemptchanops.cpp +++ b/src/modules/m_exemptchanops.cpp @@ -28,8 +28,7 @@ class ExemptChanOps : public ListModeBase public: ExemptChanOps(Module* Creator) : ListModeBase(Creator, "exemptchanops", 'X', "End of channel exemptchanops list", 954, 953, false, "exemptchanops") { } - bool ValidateParam(User* user, Channel* chan, std::string &word) - { + bool ValidateParam(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { std::string::size_type p = word.find(':'); if (p == std::string::npos) { @@ -53,17 +52,17 @@ class ExemptChanOps : public ListModeBase return true; } - void TellListTooLong(User* user, Channel* chan, std::string &word) + void TellListTooLong(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(959, chan->name, word, "Channel exemptchanops list is full"); } - void TellAlreadyOnList(User* user, Channel* chan, std::string &word) + void TellAlreadyOnList(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(957, chan->name, InspIRCd::Format("The word %s is already on the exemptchanops list", word.c_str())); } - void TellNotSet(User* user, Channel* chan, std::string &word) + void TellNotSet(User* user, Channel* chan, std::string& word) CXX11_OVERRIDE { user->WriteNumeric(958, chan->name, "No such exemptchanops word is set"); } diff --git a/src/modules/m_filter.cpp b/src/modules/m_filter.cpp index 0badd1377..8e43d2767 100644 --- a/src/modules/m_filter.cpp +++ b/src/modules/m_filter.cpp @@ -146,9 +146,9 @@ class CommandFilter : public Command flags_needed = 'o'; this->syntax = "<filter-definition> <action> <flags> [<gline-duration>] :<reason>"; } - CmdResult Handle(const std::vector<std::string>&, User*); + CmdResult Handle(const std::vector<std::string>& , User* ) CXX11_OVERRIDE; - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/modules/m_globalload.cpp b/src/modules/m_globalload.cpp index 36a90bf55..1de0aea8b 100644 --- a/src/modules/m_globalload.cpp +++ b/src/modules/m_globalload.cpp @@ -35,7 +35,7 @@ class CommandGloadmodule : public Command syntax = "<modulename> [servermask]"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { std::string servername = parameters.size() > 1 ? parameters[1] : "*"; @@ -57,7 +57,7 @@ class CommandGloadmodule : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } @@ -74,7 +74,7 @@ class CommandGunloadmodule : public Command syntax = "<modulename> [servermask]"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (!ServerInstance->Config->ConfValue("security")->getBool("allowcoreunload") && InspIRCd::Match(parameters[0], "core_*.so", ascii_case_insensitive_map)) @@ -109,7 +109,7 @@ class CommandGunloadmodule : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } @@ -125,7 +125,7 @@ class CommandGreloadmodule : public Command flags_needed = 'o'; syntax = "<modulename> [servermask]"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { std::string servername = parameters.size() > 1 ? parameters[1] : "*"; @@ -149,7 +149,7 @@ class CommandGreloadmodule : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/modules/m_globops.cpp b/src/modules/m_globops.cpp index 1cb87324b..1fe911e80 100644 --- a/src/modules/m_globops.cpp +++ b/src/modules/m_globops.cpp @@ -33,7 +33,7 @@ class CommandGlobops : public Command flags_needed = 'o'; syntax = "<any-text>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { ServerInstance->SNO->WriteGlobalSno('g', "From " + user->nick + ": " + parameters[0]); return CMD_SUCCESS; diff --git a/src/modules/m_helpop.cpp b/src/modules/m_helpop.cpp index 95f69774b..ecab97ca2 100644 --- a/src/modules/m_helpop.cpp +++ b/src/modules/m_helpop.cpp @@ -50,7 +50,7 @@ class CommandHelpop : public Command syntax = "<any-text>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { const std::string& parameter = (!parameters.empty() ? parameters[0] : startkey); diff --git a/src/modules/m_hidelist.cpp b/src/modules/m_hidelist.cpp index 97173c14b..0691ab81c 100644 --- a/src/modules/m_hidelist.cpp +++ b/src/modules/m_hidelist.cpp @@ -31,7 +31,7 @@ class ListWatcher : public ModeWatcher { } - bool BeforeMode(User* user, User* destuser, Channel* chan, std::string& param, bool adding) + bool BeforeMode(User* user, User* destuser, Channel* chan, std::string& param, bool adding) CXX11_OVERRIDE { // Only handle listmode list requests if (!param.empty()) diff --git a/src/modules/m_hideoper.cpp b/src/modules/m_hideoper.cpp index 6650b7f16..2e0b388cf 100644 --- a/src/modules/m_hideoper.cpp +++ b/src/modules/m_hideoper.cpp @@ -34,7 +34,7 @@ class HideOper : public SimpleUserModeHandler oper = true; } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { if (SimpleUserModeHandler::OnModeChange(source, dest, channel, parameter, adding) == MODEACTION_DENY) return MODEACTION_DENY; diff --git a/src/modules/m_joinflood.cpp b/src/modules/m_joinflood.cpp index 077ceff52..b4a8f6181 100644 --- a/src/modules/m_joinflood.cpp +++ b/src/modules/m_joinflood.cpp @@ -93,7 +93,7 @@ class JoinFlood : public ParamMode<JoinFlood, SimpleExtItem<joinfloodsettings> > { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { std::string::size_type colon = parameter.find(':'); if ((colon == std::string::npos) || (parameter.find('-') != std::string::npos)) diff --git a/src/modules/m_jumpserver.cpp b/src/modules/m_jumpserver.cpp index 89391c8a4..3104a0c55 100644 --- a/src/modules/m_jumpserver.cpp +++ b/src/modules/m_jumpserver.cpp @@ -42,7 +42,7 @@ class CommandJumpserver : public Command redirect_new_users = false; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { int n_done = 0; reason = (parameters.size() < 4) ? "Please use this server/port instead" : parameters[3]; diff --git a/src/modules/m_kicknorejoin.cpp b/src/modules/m_kicknorejoin.cpp index ad8bfdcb6..1bc11948c 100644 --- a/src/modules/m_kicknorejoin.cpp +++ b/src/modules/m_kicknorejoin.cpp @@ -91,7 +91,7 @@ class KickRejoin : public ParamMode<KickRejoin, SimpleExtItem<KickRejoinData> > { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { int v = ConvToInt(parameter); if (v <= 0) diff --git a/src/modules/m_knock.cpp b/src/modules/m_knock.cpp index cf623c4ab..48ed3c06f 100644 --- a/src/modules/m_knock.cpp +++ b/src/modules/m_knock.cpp @@ -40,7 +40,7 @@ class CommandKnock : public Command Penalty = 5; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { Channel* c = ServerInstance->FindChan(parameters[0]); if (!c) @@ -77,7 +77,7 @@ class CommandKnock : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_BCAST; } diff --git a/src/modules/m_lockserv.cpp b/src/modules/m_lockserv.cpp index 068573e0d..48d9801ee 100644 --- a/src/modules/m_lockserv.cpp +++ b/src/modules/m_lockserv.cpp @@ -42,7 +42,7 @@ class CommandLockserv : public Command flags_needed = 'o'; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (!locked.empty()) { @@ -67,7 +67,7 @@ class CommandUnlockserv : public Command flags_needed = 'o'; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (locked.empty()) { diff --git a/src/modules/m_md5.cpp b/src/modules/m_md5.cpp index 26ff4cffc..8de70872f 100644 --- a/src/modules/m_md5.cpp +++ b/src/modules/m_md5.cpp @@ -235,7 +235,7 @@ class MD5Provider : public HashProvider } public: - std::string GenerateRaw(const std::string& data) + std::string GenerateRaw(const std::string& data) CXX11_OVERRIDE { char res[16]; MyMD5(res, (void*)data.data(), data.length()); diff --git a/src/modules/m_messageflood.cpp b/src/modules/m_messageflood.cpp index bf651bb65..9d2e0e681 100644 --- a/src/modules/m_messageflood.cpp +++ b/src/modules/m_messageflood.cpp @@ -72,7 +72,7 @@ class MsgFlood : public ParamMode<MsgFlood, SimpleExtItem<floodsettings> > { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { std::string::size_type colon = parameter.find(':'); if ((colon == std::string::npos) || (parameter.find('-') != std::string::npos)) diff --git a/src/modules/m_modenotice.cpp b/src/modules/m_modenotice.cpp index 056eb4a62..3d12f98d1 100644 --- a/src/modules/m_modenotice.cpp +++ b/src/modules/m_modenotice.cpp @@ -28,7 +28,7 @@ class CommandModeNotice : public Command flags_needed = 'o'; } - CmdResult Handle(const std::vector<std::string>& parameters, User *src) + CmdResult Handle(const std::vector<std::string>& parameters, User* src) CXX11_OVERRIDE { std::string msg = "*** From " + src->nick + ": " + parameters[1]; int mlen = parameters[0].length(); @@ -47,7 +47,7 @@ next_user: ; return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_BCAST; } diff --git a/src/modules/m_monitor.cpp b/src/modules/m_monitor.cpp index c69732a73..af792743a 100644 --- a/src/modules/m_monitor.cpp +++ b/src/modules/m_monitor.cpp @@ -82,7 +82,7 @@ class IRCv3::Monitor::Manager free(unset_raw(container)); } - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE { std::string ret; if (format == FORMAT_NETWORK) @@ -99,9 +99,9 @@ class IRCv3::Monitor::Manager return ret; } - void unserialize(SerializeFormat format, Extensible* container, const std::string& value); + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE; - void free(void* item) + void free(void* item) CXX11_OVERRIDE { delete static_cast<ExtData*>(item); } @@ -319,7 +319,7 @@ class CommandMonitor : public SplitCommand syntax = "[C|L|S|+ <nick1>[,<nick2>]|- <nick1>[,<nick2>]"; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { char subcmd = toupper(parameters[0][0]); if (subcmd == '+') diff --git a/src/modules/m_namedmodes.cpp b/src/modules/m_namedmodes.cpp index 7f2687d66..cd63f4298 100644 --- a/src/modules/m_namedmodes.cpp +++ b/src/modules/m_namedmodes.cpp @@ -52,7 +52,7 @@ class CommandProp : public SplitCommand syntax = "<user|channel> {[+-]<mode> [<value>]}*"; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* src) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* src) CXX11_OVERRIDE { Channel* const chan = ServerInstance->FindChan(parameters[0]); if (!chan) @@ -103,7 +103,7 @@ class DummyZ : public ModeHandler } // Handle /MODE #chan Z - void DisplayList(User* user, Channel* chan) + void DisplayList(User* user, Channel* chan) CXX11_OVERRIDE { if (IS_LOCAL(user)) ::DisplayList(static_cast<LocalUser*>(user), chan); diff --git a/src/modules/m_nationalchars.cpp b/src/modules/m_nationalchars.cpp index d03468de7..bb95ecc93 100644 --- a/src/modules/m_nationalchars.cpp +++ b/src/modules/m_nationalchars.cpp @@ -31,7 +31,7 @@ class lwbNickHandler : public HandlerBase1<bool, const std::string&> { public: - bool Call(const std::string&); + bool Call(const std::string&) CXX11_OVERRIDE; }; /*,m_reverse_additionalUp[256];*/ diff --git a/src/modules/m_nickflood.cpp b/src/modules/m_nickflood.cpp index bf36fb430..e3b448871 100644 --- a/src/modules/m_nickflood.cpp +++ b/src/modules/m_nickflood.cpp @@ -90,7 +90,7 @@ class NickFlood : public ParamMode<NickFlood, SimpleExtItem<nickfloodsettings> > { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { std::string::size_type colon = parameter.find(':'); if ((colon == std::string::npos) || (parameter.find('-') != std::string::npos)) diff --git a/src/modules/m_nicklock.cpp b/src/modules/m_nicklock.cpp index fae9d36d8..afdb0b1dc 100644 --- a/src/modules/m_nicklock.cpp +++ b/src/modules/m_nicklock.cpp @@ -44,7 +44,7 @@ class CommandNicklock : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* target = ServerInstance->FindNick(parameters[0]); @@ -84,7 +84,7 @@ class CommandNicklock : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } @@ -104,7 +104,7 @@ class CommandNickunlock : public Command TRANSLATE1(TR_NICK); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* target = ServerInstance->FindNick(parameters[0]); @@ -131,7 +131,7 @@ class CommandNickunlock : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_ojoin.cpp b/src/modules/m_ojoin.cpp index a96e47bc6..2752a6ea8 100644 --- a/src/modules/m_ojoin.cpp +++ b/src/modules/m_ojoin.cpp @@ -38,7 +38,7 @@ class CommandOjoin : public SplitCommand active = false; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { // Make sure the channel name is allowable. if (!ServerInstance->IsChannel(parameters[0])) @@ -92,7 +92,7 @@ class NetworkPrefix : public PrefixMode ranktoset = ranktounset = UINT_MAX; } - ModResult AccessCheck(User* source, Channel* channel, std::string ¶meter, bool adding) + ModResult AccessCheck(User* source, Channel* channel, std::string ¶meter, bool adding) CXX11_OVERRIDE { User* theuser = ServerInstance->FindNick(parameter); // remove own privs? diff --git a/src/modules/m_opermotd.cpp b/src/modules/m_opermotd.cpp index 2431853c2..30f2ce303 100644 --- a/src/modules/m_opermotd.cpp +++ b/src/modules/m_opermotd.cpp @@ -34,14 +34,14 @@ class CommandOpermotd : public Command flags_needed = 'o'; syntax = "[<servername>]"; } - CmdResult Handle (const std::vector<std::string>& parameters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if ((parameters.empty()) || (parameters[0] == ServerInstance->Config->ServerName)) ShowOperMOTD(user); return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if ((!parameters.empty()) && (parameters[0].find('.') != std::string::npos)) return ROUTE_OPT_UCAST(parameters[0]); diff --git a/src/modules/m_operprefix.cpp b/src/modules/m_operprefix.cpp index 8b68dbe60..a8afd7c96 100644 --- a/src/modules/m_operprefix.cpp +++ b/src/modules/m_operprefix.cpp @@ -44,7 +44,7 @@ class HideOperWatcher : public ModeWatcher public: HideOperWatcher(ModuleOperPrefixMode* parent); - void AfterMode(User* source, User* dest, Channel* channel, const std::string ¶meter, bool adding); + void AfterMode(User* source, User* dest, Channel* channel, const std::string ¶meter, bool adding) CXX11_OVERRIDE; }; class ModuleOperPrefixMode : public Module diff --git a/src/modules/m_password_hash.cpp b/src/modules/m_password_hash.cpp index 09cdbb402..33757ce65 100644 --- a/src/modules/m_password_hash.cpp +++ b/src/modules/m_password_hash.cpp @@ -70,7 +70,7 @@ class CommandMkpasswd : public Command } } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { MakeHash(user, parameters[0], parameters[1]); diff --git a/src/modules/m_permchannels.cpp b/src/modules/m_permchannels.cpp index 0f2a2ef6f..7e28c5fc6 100644 --- a/src/modules/m_permchannels.cpp +++ b/src/modules/m_permchannels.cpp @@ -34,7 +34,7 @@ class PermChannel : public ModeHandler oper = true; } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { if (adding == channel->IsModeSet(this)) return MODEACTION_DENY; diff --git a/src/modules/m_redirect.cpp b/src/modules/m_redirect.cpp index 77a4925fc..479dd6d0f 100644 --- a/src/modules/m_redirect.cpp +++ b/src/modules/m_redirect.cpp @@ -32,7 +32,7 @@ class Redirect : public ParamMode<Redirect, LocalStringExt> Redirect(Module* Creator) : ParamMode<Redirect, LocalStringExt>(Creator, "redirect", 'L') { } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { if (IS_LOCAL(source)) { diff --git a/src/modules/m_remove.cpp b/src/modules/m_remove.cpp index 5872b5978..dfe624702 100644 --- a/src/modules/m_remove.cpp +++ b/src/modules/m_remove.cpp @@ -164,7 +164,7 @@ class CommandRemove : public RemoveBase TRANSLATE3(TR_NICK, TR_TEXT, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { return HandleRMB(parameters, user, false); } @@ -182,7 +182,7 @@ class CommandFpart : public RemoveBase TRANSLATE3(TR_TEXT, TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { return HandleRMB(parameters, user, true); } diff --git a/src/modules/m_repeat.cpp b/src/modules/m_repeat.cpp index f1ebe18e5..75105ca0d 100644 --- a/src/modules/m_repeat.cpp +++ b/src/modules/m_repeat.cpp @@ -135,7 +135,7 @@ class RepeatMode : public ParamMode<RepeatMode, SimpleExtItem<ChannelSettings> > MemberInfoExt.unset(i->second); } - ModeAction OnSet(User* source, Channel* channel, std::string& parameter) + ModeAction OnSet(User* source, Channel* channel, std::string& parameter) CXX11_OVERRIDE { ChannelSettings settings; if (!ParseSettings(source, parameter, settings)) diff --git a/src/modules/m_ripemd160.cpp b/src/modules/m_ripemd160.cpp index 8d3131bc0..98910db82 100644 --- a/src/modules/m_ripemd160.cpp +++ b/src/modules/m_ripemd160.cpp @@ -434,7 +434,7 @@ class RIProv : public HashProvider return (byte *)hashcode; } public: - std::string GenerateRaw(const std::string& data) + std::string GenerateRaw(const std::string& data) CXX11_OVERRIDE { char* rv = (char*)RMD((byte*)data.data(), data.length(), NULL); return std::string(rv, RMDsize / 8); diff --git a/src/modules/m_rline.cpp b/src/modules/m_rline.cpp index 6fd7b832c..9bb1167f5 100644 --- a/src/modules/m_rline.cpp +++ b/src/modules/m_rline.cpp @@ -56,7 +56,7 @@ class RLine : public XLine delete regex; } - bool Matches(User *u) + bool Matches(User* u) CXX11_OVERRIDE { LocalUser* lu = IS_LOCAL(u); if (lu && lu->exempt) @@ -67,12 +67,12 @@ class RLine : public XLine return (regex->Matches(host) || regex->Matches(ip)); } - bool Matches(const std::string &compare) + bool Matches(const std::string& compare) CXX11_OVERRIDE { return regex->Matches(compare); } - void Apply(User* u) + void Apply(User* u) CXX11_OVERRIDE { if (ZlineOnMatch) { @@ -90,7 +90,7 @@ class RLine : public XLine DefaultApply(u, "R", false); } - const std::string& Displayable() + const std::string& Displayable() CXX11_OVERRIDE { return matchtext; } @@ -113,7 +113,7 @@ class RLineFactory : public XLineFactory /** Generate a RLine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { if (!rxfactory) { @@ -139,7 +139,7 @@ class CommandRLine : public Command flags_needed = 'o'; this->syntax = "<regex> [<rline-duration>] :<reason>"; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters.size() >= 3) @@ -197,7 +197,7 @@ class CommandRLine : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if (IS_LOCAL(user)) return ROUTE_LOCALONLY; // spanningtree will send ADDLINE diff --git a/src/modules/m_rmode.cpp b/src/modules/m_rmode.cpp index 7c15247be..dbe69eca1 100644 --- a/src/modules/m_rmode.cpp +++ b/src/modules/m_rmode.cpp @@ -31,7 +31,7 @@ class CommandRMode : public Command syntax = "<channel> <mode> [pattern]"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { ModeHandler* mh; Channel* chan = ServerInstance->FindChan(parameters[0]); diff --git a/src/modules/m_sajoin.cpp b/src/modules/m_sajoin.cpp index 8bf865319..0af2e1e3e 100644 --- a/src/modules/m_sajoin.cpp +++ b/src/modules/m_sajoin.cpp @@ -33,7 +33,7 @@ class CommandSajoin : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { const unsigned int channelindex = (parameters.size() > 1) ? 1 : 0; if (CommandParser::LoopCall(user, this, parameters, channelindex)) @@ -101,7 +101,7 @@ class CommandSajoin : public Command } } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_sakick.cpp b/src/modules/m_sakick.cpp index 81a74502b..93b1c3912 100644 --- a/src/modules/m_sakick.cpp +++ b/src/modules/m_sakick.cpp @@ -31,7 +31,7 @@ class CommandSakick : public Command TRANSLATE3(TR_TEXT, TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[1]); Channel* channel = ServerInstance->FindChan(parameters[0]); @@ -73,7 +73,7 @@ class CommandSakick : public Command return CMD_FAILURE; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[1]); } diff --git a/src/modules/m_samode.cpp b/src/modules/m_samode.cpp index 394cea722..5c3d59edb 100644 --- a/src/modules/m_samode.cpp +++ b/src/modules/m_samode.cpp @@ -35,7 +35,7 @@ class CommandSamode : public Command active = false; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters[0].c_str()[0] != '#') { diff --git a/src/modules/m_sanick.cpp b/src/modules/m_sanick.cpp index c9ceba78e..a6bb4db4c 100644 --- a/src/modules/m_sanick.cpp +++ b/src/modules/m_sanick.cpp @@ -33,7 +33,7 @@ class CommandSanick : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* target = ServerInstance->FindNick(parameters[0]); @@ -77,7 +77,7 @@ class CommandSanick : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_sapart.cpp b/src/modules/m_sapart.cpp index b51316dc5..bdc78142b 100644 --- a/src/modules/m_sapart.cpp +++ b/src/modules/m_sapart.cpp @@ -32,7 +32,7 @@ class CommandSapart : public Command TRANSLATE3(TR_NICK, TR_TEXT, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (CommandParser::LoopCall(user, this, parameters, 1)) return CMD_FAILURE; @@ -78,7 +78,7 @@ class CommandSapart : public Command return CMD_FAILURE; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_saquit.cpp b/src/modules/m_saquit.cpp index 9f700ec5f..6e8ab6069 100644 --- a/src/modules/m_saquit.cpp +++ b/src/modules/m_saquit.cpp @@ -32,7 +32,7 @@ class CommandSaquit : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); if ((dest) && (dest->registered == REG_ALL)) @@ -59,7 +59,7 @@ class CommandSaquit : public Command } } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_sasl.cpp b/src/modules/m_sasl.cpp index e8a0e12a9..d5cf94c0c 100644 --- a/src/modules/m_sasl.cpp +++ b/src/modules/m_sasl.cpp @@ -304,7 +304,7 @@ class CommandAuthenticate : public SplitCommand allow_empty_last_param = false; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { { if (!cap.get(user)) @@ -341,7 +341,7 @@ class CommandSASL : public Command this->flags_needed = FLAG_SERVERONLY; // should not be called by users } - CmdResult Handle(const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* target = ServerInstance->FindUUID(parameters[1]); if (!target) @@ -363,7 +363,7 @@ class CommandSASL : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/modules/m_satopic.cpp b/src/modules/m_satopic.cpp index f45d9c8cd..56fa528f4 100644 --- a/src/modules/m_satopic.cpp +++ b/src/modules/m_satopic.cpp @@ -29,7 +29,7 @@ class CommandSATopic : public Command flags_needed = 'o'; syntax = "<target> <topic>"; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* * Handles a SATOPIC request. Notifies all +s users. diff --git a/src/modules/m_services_account.cpp b/src/modules/m_services_account.cpp index f413a04d0..2a5915f25 100644 --- a/src/modules/m_services_account.cpp +++ b/src/modules/m_services_account.cpp @@ -43,7 +43,7 @@ class Channel_r : public ModeHandler public: Channel_r(Module* Creator) : ModeHandler(Creator, "c_registered", 'r', PARAM_NONE, MODETYPE_CHANNEL) { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { // only a u-lined server may add or remove the +r mode. if (!IS_LOCAL(source)) @@ -71,7 +71,7 @@ class User_r : public ModeHandler public: User_r(Module* Creator) : ModeHandler(Creator, "u_registered", 'r', PARAM_NONE, MODETYPE_USER) { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { if (!IS_LOCAL(source)) { @@ -100,7 +100,7 @@ class AccountExtItemImpl : public AccountExtItem { } - void unserialize(SerializeFormat format, Extensible* container, const std::string& value) + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE { User* user = static_cast<User*>(container); diff --git a/src/modules/m_servprotect.cpp b/src/modules/m_servprotect.cpp index 97670237b..dae646576 100644 --- a/src/modules/m_servprotect.cpp +++ b/src/modules/m_servprotect.cpp @@ -28,7 +28,7 @@ class ServProtectMode : public ModeHandler public: ServProtectMode(Module* Creator) : ModeHandler(Creator, "servprotect", 'k', PARAM_NONE, MODETYPE_USER) { oper = true; } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { /* Because this returns MODEACTION_DENY all the time, there is only ONE * way to add this mode and that is at client introduction in the UID command, diff --git a/src/modules/m_sethost.cpp b/src/modules/m_sethost.cpp index b37207b4f..23dbbad56 100644 --- a/src/modules/m_sethost.cpp +++ b/src/modules/m_sethost.cpp @@ -34,7 +34,7 @@ class CommandSethost : public Command flags_needed = 'o'; syntax = "<new-hostname>"; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters[0].length() > ServerInstance->Config->Limits.MaxHost) { diff --git a/src/modules/m_setident.cpp b/src/modules/m_setident.cpp index 93dd4c332..beb7611ab 100644 --- a/src/modules/m_setident.cpp +++ b/src/modules/m_setident.cpp @@ -33,7 +33,7 @@ class CommandSetident : public Command flags_needed = 'o'; syntax = "<new-ident>"; } - CmdResult Handle(const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters[0].size() > ServerInstance->Config->Limits.IdentMax) { diff --git a/src/modules/m_setidle.cpp b/src/modules/m_setidle.cpp index 6302b3654..0f224e9e9 100644 --- a/src/modules/m_setidle.cpp +++ b/src/modules/m_setidle.cpp @@ -38,7 +38,7 @@ class CommandSetidle : public SplitCommand flags_needed = 'o'; syntax = "<duration>"; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { int idle = InspIRCd::Duration(parameters[0]); if (idle < 1) diff --git a/src/modules/m_setname.cpp b/src/modules/m_setname.cpp index 0e71840f7..34428e9c0 100644 --- a/src/modules/m_setname.cpp +++ b/src/modules/m_setname.cpp @@ -32,7 +32,7 @@ class CommandSetname : public Command syntax = "<new-gecos>"; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (parameters[0].size() > ServerInstance->Config->Limits.MaxGecos) { diff --git a/src/modules/m_sha1.cpp b/src/modules/m_sha1.cpp index 798539d91..561a7b6cb 100644 --- a/src/modules/m_sha1.cpp +++ b/src/modules/m_sha1.cpp @@ -170,7 +170,7 @@ class SHA1HashProvider : public HashProvider { } - std::string GenerateRaw(const std::string& data) + std::string GenerateRaw(const std::string& data) CXX11_OVERRIDE { SHA1Context ctx; ctx.Update(reinterpret_cast<const unsigned char*>(data.data()), data.length()); diff --git a/src/modules/m_sha256.cpp b/src/modules/m_sha256.cpp index 48bfc0041..d905ab9b4 100644 --- a/src/modules/m_sha256.cpp +++ b/src/modules/m_sha256.cpp @@ -247,7 +247,7 @@ class HashSHA256 : public HashProvider } public: - std::string GenerateRaw(const std::string& data) + std::string GenerateRaw(const std::string& data) CXX11_OVERRIDE { unsigned char bytes[SHA256_DIGEST_SIZE]; SHA256(data.data(), bytes, data.length()); diff --git a/src/modules/m_showwhois.cpp b/src/modules/m_showwhois.cpp index 99774563d..b8091d060 100644 --- a/src/modules/m_showwhois.cpp +++ b/src/modules/m_showwhois.cpp @@ -54,7 +54,7 @@ class WhoisNoticeCmd : public Command ") did a /whois on you"); } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); if (!dest) diff --git a/src/modules/m_shun.cpp b/src/modules/m_shun.cpp index 66cc7fd58..d68f58dd4 100644 --- a/src/modules/m_shun.cpp +++ b/src/modules/m_shun.cpp @@ -34,7 +34,7 @@ public: { } - bool Matches(User *u) + bool Matches(User* u) CXX11_OVERRIDE { // E: overrides shun LocalUser* lu = IS_LOCAL(u); @@ -50,14 +50,14 @@ public: return false; } - bool Matches(const std::string &s) + bool Matches(const std::string& s) CXX11_OVERRIDE { if (matchtext == s) return true; return false; } - const std::string& Displayable() + const std::string& Displayable() CXX11_OVERRIDE { return matchtext; } @@ -72,12 +72,12 @@ class ShunFactory : public XLineFactory /** Generate a shun */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { return new Shun(set_time, duration, source, reason, xline_specific_mask); } - bool AutoApplyToUserList(XLine *x) + bool AutoApplyToUserList(XLine* x) CXX11_OVERRIDE { return false; } @@ -93,7 +93,7 @@ class CommandShun : public Command flags_needed = 'o'; this->syntax = "<nick!user@hostmask> [<shun-duration>] :<reason>"; } - CmdResult Handle(const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* syntax: SHUN nick!user@host time :reason goes here */ /* 'time' is a human-readable timestring, like 2d3h2s. */ @@ -162,7 +162,7 @@ class CommandShun : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { if (IS_LOCAL(user)) return ROUTE_LOCALONLY; // spanningtree will send ADDLINE diff --git a/src/modules/m_silence.cpp b/src/modules/m_silence.cpp index cb065d2fc..edcc77468 100644 --- a/src/modules/m_silence.cpp +++ b/src/modules/m_silence.cpp @@ -67,7 +67,7 @@ class CommandSVSSilence : public Command TRANSLATE3(TR_NICK, TR_TEXT, TR_TEXT); } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* * XXX: thought occurs to me @@ -91,7 +91,7 @@ class CommandSVSSilence : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } @@ -110,7 +110,7 @@ class CommandSilence : public Command syntax = "{[+|-]<mask> <p|c|i|n|t|a|x>}"; } - CmdResult Handle (const std::vector<std::string>& parameters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (!parameters.size()) { diff --git a/src/modules/m_spanningtree/cachetimer.h b/src/modules/m_spanningtree/cachetimer.h index cffbe3578..489194b86 100644 --- a/src/modules/m_spanningtree/cachetimer.h +++ b/src/modules/m_spanningtree/cachetimer.h @@ -25,5 +25,5 @@ class CacheRefreshTimer : public Timer { public: CacheRefreshTimer(); - bool Tick(time_t TIME); + bool Tick(time_t TIME) CXX11_OVERRIDE; }; diff --git a/src/modules/m_spanningtree/commands.h b/src/modules/m_spanningtree/commands.h index 8eea02915..05fafd1a7 100644 --- a/src/modules/m_spanningtree/commands.h +++ b/src/modules/m_spanningtree/commands.h @@ -44,55 +44,55 @@ class CommandRConnect : public Command { public: CommandRConnect(Module* Creator); - CmdResult Handle(const std::vector<std::string>& parameters, User* user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandRSQuit : public Command { public: CommandRSQuit(Module* Creator); - CmdResult Handle(const std::vector<std::string>& parameters, User* user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandMap : public Command { public: CommandMap(Module* Creator); - CmdResult Handle(const std::vector<std::string>& parameters, User* user); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandSVSJoin : public ServerCommand { public: CommandSVSJoin(Module* Creator) : ServerCommand(Creator, "SVSJOIN", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& params); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandSVSPart : public ServerCommand { public: CommandSVSPart(Module* Creator) : ServerCommand(Creator, "SVSPART", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& params); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandSVSNick : public ServerCommand { public: CommandSVSNick(Module* Creator) : ServerCommand(Creator, "SVSNICK", 3) { } - CmdResult Handle(User* user, std::vector<std::string>& params); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandMetadata : public ServerCommand { public: CommandMetadata(Module* Creator) : ServerCommand(Creator, "METADATA", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& params); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; class Builder : public CmdBuilder { @@ -149,8 +149,8 @@ class CommandFJoin : public ServerCommand void ProcessModeUUIDPair(const std::string& item, TreeServer* sourceserver, Channel* chan, Modes::ChangeList* modechangelist, FwdFJoinBuilder& fwdfjoin); public: CommandFJoin(Module* Creator) : ServerCommand(Creator, "FJOIN", 3) { } - CmdResult Handle(User* user, std::vector<std::string>& params); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) { return ROUTE_LOCALONLY; } + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_LOCALONLY; } class Builder : public CmdBuilder { @@ -186,14 +186,14 @@ class CommandFMode : public ServerCommand { public: CommandFMode(Module* Creator) : ServerCommand(Creator, "FMODE", 3) { } - CmdResult Handle(User* user, std::vector<std::string>& params); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; }; class CommandFTopic : public ServerCommand { public: CommandFTopic(Module* Creator) : ServerCommand(Creator, "FTOPIC", 4, 5) { } - CmdResult Handle(User* user, std::vector<std::string>& params); + CmdResult Handle(User* user, std::vector<std::string>& params) CXX11_OVERRIDE; class Builder : public CmdBuilder { @@ -236,7 +236,7 @@ class CommandResync : public ServerOnlyServerCommand<CommandResync> public: CommandResync(Module* Creator) : ServerOnlyServerCommand<CommandResync>(Creator, "RESYNC", 1) { } CmdResult HandleServer(TreeServer* server, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) { return ROUTE_LOCALONLY; } + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_LOCALONLY; } }; class SpanningTree::CommandAway : public UserOnlyServerCommand<SpanningTree::CommandAway> @@ -258,7 +258,7 @@ class CommandAddLine : public ServerCommand { public: CommandAddLine(Module* Creator) : ServerCommand(Creator, "ADDLINE", 6, 6) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; class Builder : public CmdBuilder { @@ -271,15 +271,15 @@ class CommandDelLine : public ServerCommand { public: CommandDelLine(Module* Creator) : ServerCommand(Creator, "DELLINE", 2, 2) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandEncap : public ServerCommand { public: CommandEncap(Module* Creator) : ServerCommand(Creator, "ENCAP", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandIdle : public UserOnlyServerCommand<CommandIdle> @@ -287,7 +287,7 @@ class CommandIdle : public UserOnlyServerCommand<CommandIdle> public: CommandIdle(Module* Creator) : UserOnlyServerCommand<CommandIdle>(Creator, "IDLE", 1) { } CmdResult HandleRemote(RemoteUser* user, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) { return ROUTE_UNICAST(parameters[0]); } + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_UNICAST(parameters[0]); } }; class SpanningTree::CommandNick : public UserOnlyServerCommand<SpanningTree::CommandNick> @@ -301,8 +301,8 @@ class SpanningTree::CommandPing : public ServerCommand { public: CommandPing(Module* Creator) : ServerCommand(Creator, "PING", 1) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) { return ROUTE_UNICAST(parameters[0]); } + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_UNICAST(parameters[0]); } }; class SpanningTree::CommandPong : public ServerOnlyServerCommand<SpanningTree::CommandPong> @@ -310,7 +310,7 @@ class SpanningTree::CommandPong : public ServerOnlyServerCommand<SpanningTree::C public: CommandPong(Module* Creator) : ServerOnlyServerCommand<SpanningTree::CommandPong>(Creator, "PONG", 1) { } CmdResult HandleServer(TreeServer* server, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) { return ROUTE_UNICAST(parameters[0]); } + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_UNICAST(parameters[0]); } }; class CommandSave : public ServerCommand @@ -321,7 +321,7 @@ class CommandSave : public ServerCommand static const time_t SavedTimestamp = 100; CommandSave(Module* Creator) : ServerCommand(Creator, "SAVE", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class SpanningTree::CommandServer : public ServerOnlyServerCommand<SpanningTree::CommandServer> @@ -354,7 +354,7 @@ class CommandSNONotice : public ServerCommand { public: CommandSNONotice(Module* Creator) : ServerCommand(Creator, "SNONOTICE", 2) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters); + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE; }; class CommandEndBurst : public ServerOnlyServerCommand<CommandEndBurst> @@ -382,7 +382,7 @@ class CommandNum : public ServerOnlyServerCommand<CommandNum> public: CommandNum(Module* Creator) : ServerOnlyServerCommand<CommandNum>(Creator, "NUM", 3) { } CmdResult HandleServer(TreeServer* server, std::vector<std::string>& parameters); - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters); + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; class Builder : public CmdBuilder { diff --git a/src/modules/m_spanningtree/servercommand.h b/src/modules/m_spanningtree/servercommand.h index ee7766764..84488bd68 100644 --- a/src/modules/m_spanningtree/servercommand.h +++ b/src/modules/m_spanningtree/servercommand.h @@ -43,7 +43,7 @@ class ServerCommand : public CommandBase void RegisterService() CXX11_OVERRIDE; virtual CmdResult Handle(User* user, std::vector<std::string>& parameters) = 0; - virtual RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE; /** * Extract the TS from a string. @@ -65,7 +65,7 @@ class UserOnlyServerCommand : public ServerCommand UserOnlyServerCommand(Module* Creator, const std::string& Name, unsigned int MinPara = 0, unsigned int MaxPara = 0) : ServerCommand(Creator, Name, MinPara, MaxPara) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters) + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE { RemoteUser* remoteuser = IS_REMOTE(user); if (!remoteuser) @@ -84,7 +84,7 @@ class ServerOnlyServerCommand : public ServerCommand ServerOnlyServerCommand(Module* Creator, const std::string& Name, unsigned int MinPara = 0, unsigned int MaxPara = 0) : ServerCommand(Creator, Name, MinPara, MaxPara) { } - CmdResult Handle(User* user, std::vector<std::string>& parameters) + CmdResult Handle(User* user, std::vector<std::string>& parameters) CXX11_OVERRIDE { if (!IS_SERVER(user)) throw ProtocolException("Invalid source"); diff --git a/src/modules/m_sslinfo.cpp b/src/modules/m_sslinfo.cpp index 5a5b40319..1a4b5c9a2 100644 --- a/src/modules/m_sslinfo.cpp +++ b/src/modules/m_sslinfo.cpp @@ -39,12 +39,12 @@ class SSLCertExt : public ExtensionItem { delete old; } - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE { return static_cast<ssl_cert*>(item)->GetMetaLine(); } - void unserialize(SerializeFormat format, Extensible* container, const std::string& value) + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE { ssl_cert* cert = new ssl_cert; set(container, cert); @@ -69,7 +69,7 @@ class SSLCertExt : public ExtensionItem { } } - void free(void* item) + void free(void* item) CXX11_OVERRIDE { ssl_cert* old = static_cast<ssl_cert*>(item); if (old && old->refcount_dec()) @@ -89,7 +89,7 @@ class CommandSSLInfo : public Command this->syntax = "<nick>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* target = ServerInstance->FindNickOnly(parameters[0]); diff --git a/src/modules/m_sslmodes.cpp b/src/modules/m_sslmodes.cpp index d3afd00e6..6d1d62782 100644 --- a/src/modules/m_sslmodes.cpp +++ b/src/modules/m_sslmodes.cpp @@ -43,7 +43,7 @@ class SSLMode : public ModeHandler { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { if (adding) { diff --git a/src/modules/m_starttls.cpp b/src/modules/m_starttls.cpp index b3cf5a263..d05a10c43 100644 --- a/src/modules/m_starttls.cpp +++ b/src/modules/m_starttls.cpp @@ -40,7 +40,7 @@ class CommandStartTLS : public SplitCommand works_before_reg = true; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { if (!ssl) { diff --git a/src/modules/m_svshold.cpp b/src/modules/m_svshold.cpp index ad6a4d1aa..1ba16f3f4 100644 --- a/src/modules/m_svshold.cpp +++ b/src/modules/m_svshold.cpp @@ -41,19 +41,19 @@ public: this->nickname = nick; } - bool Matches(User *u) + bool Matches(User* u) CXX11_OVERRIDE { if (u->nick == nickname) return true; return false; } - bool Matches(const std::string &s) + bool Matches(const std::string& s) CXX11_OVERRIDE { return InspIRCd::Match(s, nickname); } - void DisplayExpiry() + void DisplayExpiry() CXX11_OVERRIDE { if (!silent) { @@ -62,7 +62,7 @@ public: } } - const std::string& Displayable() + const std::string& Displayable() CXX11_OVERRIDE { return nickname; } @@ -77,12 +77,12 @@ class SVSHoldFactory : public XLineFactory /** Generate a shun */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { return new SVSHold(set_time, duration, source, reason, xline_specific_mask); } - bool AutoApplyToUserList(XLine *x) + bool AutoApplyToUserList(XLine* x) CXX11_OVERRIDE { return false; } @@ -98,7 +98,7 @@ class CommandSvshold : public Command flags_needed = 'o'; this->syntax = "<nickname> [<duration> :<reason>]"; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { /* syntax: svshold nickname time :reason goes here */ /* 'time' is a human-readable timestring, like 2d3h2s. */ @@ -155,7 +155,7 @@ class CommandSvshold : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } diff --git a/src/modules/m_swhois.cpp b/src/modules/m_swhois.cpp index 9a433e154..5c2fb6011 100644 --- a/src/modules/m_swhois.cpp +++ b/src/modules/m_swhois.cpp @@ -39,7 +39,7 @@ class CommandSwhois : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector<std::string> ¶meters, User* user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); diff --git a/src/modules/m_timedbans.cpp b/src/modules/m_timedbans.cpp index 1898ea88a..9b74b6f23 100644 --- a/src/modules/m_timedbans.cpp +++ b/src/modules/m_timedbans.cpp @@ -66,7 +66,7 @@ class CommandTban : public Command syntax = "<channel> <duration> <banmask>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { Channel* channel = ServerInstance->FindChan(parameters[0]); if (!channel) @@ -127,7 +127,7 @@ class CommandTban : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } @@ -141,7 +141,7 @@ class BanWatcher : public ModeWatcher { } - void AfterMode(User* source, User* dest, Channel* chan, const std::string& banmask, bool adding) + void AfterMode(User* source, User* dest, Channel* chan, const std::string& banmask, bool adding) CXX11_OVERRIDE { if (adding) return; diff --git a/src/modules/m_tline.cpp b/src/modules/m_tline.cpp index 77ec0e26c..a351db227 100644 --- a/src/modules/m_tline.cpp +++ b/src/modules/m_tline.cpp @@ -30,7 +30,7 @@ class CommandTline : public Command flags_needed = 'o'; this->syntax = "<mask>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { unsigned int n_matched = 0; unsigned int n_match_host = 0; diff --git a/src/modules/m_topiclock.cpp b/src/modules/m_topiclock.cpp index 8a0712c3e..9bdcdc182 100644 --- a/src/modules/m_topiclock.cpp +++ b/src/modules/m_topiclock.cpp @@ -33,7 +33,7 @@ class CommandSVSTOPIC : public Command flags_needed = FLAG_SERVERONLY; } - CmdResult Handle(const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { if (!user->server->IsULine()) { @@ -67,7 +67,7 @@ class CommandSVSTOPIC : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_BROADCAST; } @@ -86,7 +86,7 @@ class FlagExtItem : public ExtensionItem return (get_raw(container) != NULL); } - std::string serialize(SerializeFormat format, const Extensible* container, void* item) const + std::string serialize(SerializeFormat format, const Extensible* container, void* item) const CXX11_OVERRIDE { if (format == FORMAT_USER) return "true"; @@ -94,7 +94,7 @@ class FlagExtItem : public ExtensionItem return "1"; } - void unserialize(SerializeFormat format, Extensible* container, const std::string& value) + void unserialize(SerializeFormat format, Extensible* container, const std::string& value) CXX11_OVERRIDE { if (value == "1") set_raw(container, this); @@ -115,7 +115,7 @@ class FlagExtItem : public ExtensionItem unset_raw(container); } - void free(void* item) + void free(void* item) CXX11_OVERRIDE { // nothing to free } diff --git a/src/modules/m_uninvite.cpp b/src/modules/m_uninvite.cpp index d3a424dff..df43e2bb2 100644 --- a/src/modules/m_uninvite.cpp +++ b/src/modules/m_uninvite.cpp @@ -37,7 +37,7 @@ class CommandUninvite : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { User* u; if (IS_LOCAL(user)) @@ -103,7 +103,7 @@ class CommandUninvite : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) + RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_userip.cpp b/src/modules/m_userip.cpp index 7853c35af..610177cb7 100644 --- a/src/modules/m_userip.cpp +++ b/src/modules/m_userip.cpp @@ -31,7 +31,7 @@ class CommandUserip : public Command syntax = "<nick> [<nick> ...]"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { std::string retbuf; int nicks = 0; diff --git a/src/modules/m_vhost.cpp b/src/modules/m_vhost.cpp index 53910fdbe..bc10fb819 100644 --- a/src/modules/m_vhost.cpp +++ b/src/modules/m_vhost.cpp @@ -32,7 +32,7 @@ class CommandVhost : public Command syntax = "<username> <password>"; } - CmdResult Handle (const std::vector<std::string> ¶meters, User *user) + CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE { ConfigTagList tags = ServerInstance->Config->ConfTags("vhost"); for(ConfigIter i = tags.first; i != tags.second; ++i) diff --git a/src/modules/m_watch.cpp b/src/modules/m_watch.cpp index 7fa8ad8f4..ba5ce10bd 100644 --- a/src/modules/m_watch.cpp +++ b/src/modules/m_watch.cpp @@ -134,7 +134,7 @@ class CommandWatch : public SplitCommand syntax = "[<C|L|S|l|+<nick1>|-<nick>>]"; } - CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) + CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user) CXX11_OVERRIDE { if (parameters.empty()) { diff --git a/src/xline.cpp b/src/xline.cpp index f21b2b4fb..8d4c822aa 100644 --- a/src/xline.cpp +++ b/src/xline.cpp @@ -33,7 +33,7 @@ class GLineFactory : public XLineFactory /** Generate a GLine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { IdentHostPair ih = ServerInstance->XLines->IdentSplit(xline_specific_mask); return new GLine(set_time, duration, source, reason, ih.first, ih.second); @@ -49,7 +49,7 @@ class ELineFactory : public XLineFactory /** Generate an ELine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { IdentHostPair ih = ServerInstance->XLines->IdentSplit(xline_specific_mask); return new ELine(set_time, duration, source, reason, ih.first, ih.second); @@ -65,7 +65,7 @@ class KLineFactory : public XLineFactory /** Generate a KLine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { IdentHostPair ih = ServerInstance->XLines->IdentSplit(xline_specific_mask); return new KLine(set_time, duration, source, reason, ih.first, ih.second); @@ -81,7 +81,7 @@ class QLineFactory : public XLineFactory /** Generate a QLine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { return new QLine(set_time, duration, source, reason, xline_specific_mask); } @@ -96,7 +96,7 @@ class ZLineFactory : public XLineFactory /** Generate a ZLine */ - XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) + XLine* Generate(time_t set_time, long duration, std::string source, std::string reason, std::string xline_specific_mask) CXX11_OVERRIDE { return new ZLine(set_time, duration, source, reason, xline_specific_mask); } |