From d9de2ec34f82367d9770f0eec03b16e082643698 Mon Sep 17 00:00:00 2001 From: Daniel Vassdal Date: Tue, 9 Sep 2014 11:09:46 +0200 Subject: m_kicknorejoin: Advertise upper bound. Closes #913 --- src/modules/m_kicknorejoin.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/modules/m_kicknorejoin.cpp b/src/modules/m_kicknorejoin.cpp index ebe2d45c9..b8a776667 100644 --- a/src/modules/m_kicknorejoin.cpp +++ b/src/modules/m_kicknorejoin.cpp @@ -83,10 +83,11 @@ class KickRejoinData */ class KickRejoin : public ParamMode > { - static const unsigned int max = 60; + const unsigned int max; public: KickRejoin(Module* Creator) : ParamMode >(Creator, "kicknorejoin", 'J') + , max(60) { } @@ -107,6 +108,11 @@ class KickRejoin : public ParamMode > { out.append(ConvToStr(krd->delay)); } + + std::string GetModuleSettings() const + { + return ConvToStr(max); + } }; class ModuleKickNoRejoin : public Module @@ -147,7 +153,7 @@ public: Version GetVersion() CXX11_OVERRIDE { - return Version("Channel mode to delay rejoin after kick", VF_VENDOR); + return Version("Channel mode to delay rejoin after kick", VF_VENDOR | VF_COMMON, kr.GetModuleSettings()); } }; -- cgit v1.2.3 From 76608ff23d515fbf5fcdbdc17b7f261339b2a276 Mon Sep 17 00:00:00 2001 From: Daniel Vassdal Date: Tue, 9 Sep 2014 21:40:47 +0200 Subject: capab: m_kicknorejoin: Don't advertise upper bound to 2.0 servers --- src/modules/m_spanningtree/capab.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src') diff --git a/src/modules/m_spanningtree/capab.cpp b/src/modules/m_spanningtree/capab.cpp index 047808c29..9035d89c9 100644 --- a/src/modules/m_spanningtree/capab.cpp +++ b/src/modules/m_spanningtree/capab.cpp @@ -33,6 +33,11 @@ std::string TreeSocket::MyModules(int filter) std::string capabilities; for (ModuleManager::ModuleMap::const_iterator i = modlist.begin(); i != modlist.end(); ++i) { + // 2.2 advertises its settings for the benefit of services + // 2.0 would bork on this + if (proto_version < 1205 && i->second->ModuleSourceFile == "m_kicknorejoin.so") + continue; + Version v = i->second->GetVersion(); if (!(v.Flags & filter)) continue; -- cgit v1.2.3