From 2c3f10316c1fcfd137d83ecfe302d3ffeaad3e6f Mon Sep 17 00:00:00 2001 From: danieldg Date: Sat, 14 Mar 2009 14:31:48 +0000 Subject: Revert r11194 "Quiet bursts for uplinks, suggested by HiroP, thanks!" This check on uplink was not sufficient. It has been replaced by marking children of a bursting server as bursting, so the uplink is no longer needed. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11218 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_spanningtree/opertype.cpp | 7 +++---- src/modules/m_spanningtree/treesocket.h | 4 ++-- src/modules/m_spanningtree/treesocket2.cpp | 4 ++-- src/modules/m_spanningtree/uid.cpp | 10 ++-------- 4 files changed, 9 insertions(+), 16 deletions(-) (limited to 'src') diff --git a/src/modules/m_spanningtree/opertype.cpp b/src/modules/m_spanningtree/opertype.cpp index c76425fda..62016ccaf 100644 --- a/src/modules/m_spanningtree/opertype.cpp +++ b/src/modules/m_spanningtree/opertype.cpp @@ -24,7 +24,7 @@ /** Because the core won't let users or even SERVERS set +o, * we use the OPERTYPE command to do this. */ -bool TreeSocket::OperType(const std::string &prefix, std::deque ¶ms, const std::string &up) +bool TreeSocket::OperType(const std::string &prefix, std::deque ¶ms) { if (params.size() != 1) return true; @@ -39,17 +39,16 @@ bool TreeSocket::OperType(const std::string &prefix, std::deque &pa Utils->DoOneToAllButSender(u->uuid, "OPERTYPE", params, u->server); TreeServer* remoteserver = Utils->FindServer(u->server); - TreeServer* uplink = Utils->FindServer(up); bool dosend = true; - if (this->Utils->quiet_bursts && uplink) + if (this->Utils->quiet_bursts) { /* * If quiet bursts are enabled, and server is bursting or silent uline (i.e. services), * then do nothing. -- w00t */ if ( - remoteserver->bursting || uplink->bursting || + remoteserver->bursting || this->ServerInstance->SilentULine(this->ServerInstance->FindServerNamePtr(u->server)) ) { diff --git a/src/modules/m_spanningtree/treesocket.h b/src/modules/m_spanningtree/treesocket.h index 6619d6ce9..510052f31 100644 --- a/src/modules/m_spanningtree/treesocket.h +++ b/src/modules/m_spanningtree/treesocket.h @@ -220,7 +220,7 @@ class TreeSocket : public BufferedSocket int DoCollision(User *u, time_t remotets, const std::string &remoteident, const std::string &remoteip, const std::string &remoteuid); /** UID command */ - bool ParseUID(const std::string &source, std::deque ¶ms, const std::string &up); + bool ParseUID(const std::string &source, std::deque ¶ms); /** Send one or more FJOINs for a channel of users. * If the length of a single line is more than 480-NICKMAX @@ -275,7 +275,7 @@ class TreeSocket : public BufferedSocket /** Because the core won't let users or even SERVERS set +o, * we use the OPERTYPE command to do this. */ - bool OperType(const std::string &prefix, std::deque ¶ms, const std::string &up); + bool OperType(const std::string &prefix, std::deque ¶ms); /** Because Andy insists that services-compatible servers must * implement SVSNICK and SVSJOIN, that's exactly what we do :p diff --git a/src/modules/m_spanningtree/treesocket2.cpp b/src/modules/m_spanningtree/treesocket2.cpp index 06a6bc211..843b01096 100644 --- a/src/modules/m_spanningtree/treesocket2.cpp +++ b/src/modules/m_spanningtree/treesocket2.cpp @@ -316,7 +316,7 @@ bool TreeSocket::ProcessLine(std::string &line) */ if (command == "UID") { - return this->ParseUID(prefix, params, sourceserv); + return this->ParseUID(prefix, params); } else if (command == "FJOIN") { @@ -366,7 +366,7 @@ bool TreeSocket::ProcessLine(std::string &line) } else if (command == "OPERTYPE") { - return this->OperType(prefix, params, sourceserv); + return this->OperType(prefix,params); } else if (command == "FMODE") { diff --git a/src/modules/m_spanningtree/uid.cpp b/src/modules/m_spanningtree/uid.cpp index 697dbe689..58a4a0e9d 100644 --- a/src/modules/m_spanningtree/uid.cpp +++ b/src/modules/m_spanningtree/uid.cpp @@ -23,7 +23,7 @@ /* $ModDep: m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h m_hash.h m_spanningtree/handshaketimer.h */ -bool TreeSocket::ParseUID(const std::string &source, std::deque ¶ms, const std::string &up) +bool TreeSocket::ParseUID(const std::string &source, std::deque ¶ms) { /** Do we have enough parameters: * 0 1 2 3 4 5 6 7 8 9 (n-1) @@ -40,13 +40,7 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque &pa std::string empty; TreeServer* remoteserver = Utils->FindServer(source); - TreeServer* uplink = Utils->FindServer(up); - if (!uplink) - { - this->SendError("Invalid client introduction (Can't determine name of uplink!)"); - return false; - } if (!remoteserver) { this->SendError("Invalid client introduction (Unknown server "+source+")"); @@ -174,7 +168,7 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque &pa bool dosend = true; - if ((this->Utils->quiet_bursts && (remoteserver->bursting || uplink->bursting)) || this->ServerInstance->SilentULine(_new->server)) + if ((this->Utils->quiet_bursts && remoteserver->bursting) || this->ServerInstance->SilentULine(_new->server)) dosend = false; if (dosend) -- cgit v1.2.3