From 8f7cdd5b61112802973470e74a87da52ee064920 Mon Sep 17 00:00:00 2001 From: satmd Date: Sun, 1 Jun 2014 17:53:31 +0200 Subject: Fix harmless loop off-by-ones found by Moonlightning --- src/modules/m_autoop.cpp | 2 +- src/modules/m_check.cpp | 2 +- src/modules/m_exemptchanops.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/modules') diff --git a/src/modules/m_autoop.cpp b/src/modules/m_autoop.cpp index 07dca6929..0c0e8f579 100644 --- a/src/modules/m_autoop.cpp +++ b/src/modules/m_autoop.cpp @@ -38,7 +38,7 @@ class AutoOpList : public ListModeBase { if (mid.length() == 1) return ServerInstance->Modes->FindMode(mid[0], MODETYPE_CHANNEL); - for(char c='A'; c < 'z'; c++) + for(char c='A'; c <= 'z'; c++) { ModeHandler* mh = ServerInstance->Modes->FindMode(c, MODETYPE_CHANNEL); if (mh && mh->name == mid) diff --git a/src/modules/m_check.cpp b/src/modules/m_check.cpp index 07276445f..96b357f20 100644 --- a/src/modules/m_check.cpp +++ b/src/modules/m_check.cpp @@ -114,7 +114,7 @@ class CommandCheck : public Command { std::string umodes; std::string cmodes; - for(char c='A'; c < 'z'; c++) + for(char c='A'; c <= 'z'; c++) { ModeHandler* mh = ServerInstance->Modes->FindMode(c, MODETYPE_USER); if (mh && mh->NeedsOper() && loctarg->HasModePermission(c, MODETYPE_USER)) diff --git a/src/modules/m_exemptchanops.cpp b/src/modules/m_exemptchanops.cpp index 9fac8e7ad..8d6d65af2 100644 --- a/src/modules/m_exemptchanops.cpp +++ b/src/modules/m_exemptchanops.cpp @@ -68,7 +68,7 @@ class ExemptHandler : public HandlerBase3Modes->FindMode(mid[0], MODETYPE_CHANNEL); - for(char c='A'; c < 'z'; c++) + for(char c='A'; c <= 'z'; c++) { ModeHandler* mh = ServerInstance->Modes->FindMode(c, MODETYPE_CHANNEL); if (mh && mh->name == mid) -- cgit v1.2.3