From 384ef31bc01e4a1a2e59d082c9066002410ba54a Mon Sep 17 00:00:00 2001 From: Peter Powell Date: Thu, 26 Jul 2018 19:43:54 +0100 Subject: Use CommandBase::Params instead of std::vector. This is presently a typedef but will soon be replaced with a class that encapsulates both tags and parameters. --- src/modules/m_abbreviation.cpp | 2 +- src/modules/m_alias.cpp | 4 +- src/modules/m_alltime.cpp | 4 +- src/modules/m_blockamsg.cpp | 2 +- src/modules/m_callerid.cpp | 4 +- src/modules/m_cap.cpp | 2 +- src/modules/m_cban.cpp | 4 +- src/modules/m_cgiirc.cpp | 2 +- src/modules/m_check.cpp | 4 +- src/modules/m_chghost.cpp | 4 +- src/modules/m_chgident.cpp | 4 +- src/modules/m_chgname.cpp | 4 +- src/modules/m_clearchan.cpp | 4 +- src/modules/m_cloaking.cpp | 4 +- src/modules/m_clones.cpp | 2 +- src/modules/m_close.cpp | 2 +- src/modules/m_conn_umodes.cpp | 2 +- src/modules/m_conn_waitpong.cpp | 2 +- src/modules/m_customtitle.cpp | 2 +- src/modules/m_cycle.cpp | 2 +- src/modules/m_dccallow.cpp | 4 +- src/modules/m_filter.cpp | 10 +-- src/modules/m_globalload.cpp | 12 ++-- src/modules/m_globops.cpp | 2 +- src/modules/m_helpop.cpp | 2 +- src/modules/m_jumpserver.cpp | 2 +- src/modules/m_knock.cpp | 4 +- src/modules/m_ldapoper.cpp | 6 +- src/modules/m_lockserv.cpp | 4 +- src/modules/m_maphide.cpp | 2 +- src/modules/m_modenotice.cpp | 4 +- src/modules/m_monitor.cpp | 2 +- src/modules/m_namedmodes.cpp | 2 +- src/modules/m_namesx.cpp | 2 +- src/modules/m_nicklock.cpp | 8 +-- src/modules/m_ojoin.cpp | 2 +- src/modules/m_operlog.cpp | 2 +- src/modules/m_opermodes.cpp | 2 +- src/modules/m_opermotd.cpp | 4 +- src/modules/m_password_hash.cpp | 2 +- src/modules/m_remove.cpp | 14 ++-- src/modules/m_rline.cpp | 4 +- src/modules/m_rmode.cpp | 2 +- src/modules/m_sajoin.cpp | 4 +- src/modules/m_sakick.cpp | 4 +- src/modules/m_samode.cpp | 2 +- src/modules/m_sanick.cpp | 4 +- src/modules/m_sapart.cpp | 4 +- src/modules/m_saquit.cpp | 4 +- src/modules/m_sasl.cpp | 16 ++--- src/modules/m_satopic.cpp | 2 +- src/modules/m_securelist.cpp | 2 +- src/modules/m_sethost.cpp | 2 +- src/modules/m_setident.cpp | 2 +- src/modules/m_setidle.cpp | 2 +- src/modules/m_setname.cpp | 2 +- src/modules/m_showfile.cpp | 2 +- src/modules/m_showwhois.cpp | 4 +- src/modules/m_shun.cpp | 6 +- src/modules/m_silence.cpp | 9 +-- src/modules/m_spanningtree/addline.cpp | 2 +- src/modules/m_spanningtree/away.cpp | 2 +- src/modules/m_spanningtree/capab.cpp | 2 +- src/modules/m_spanningtree/commands.h | 92 ++++++++++++------------ src/modules/m_spanningtree/compat.cpp | 6 +- src/modules/m_spanningtree/delline.cpp | 2 +- src/modules/m_spanningtree/encap.cpp | 6 +- src/modules/m_spanningtree/fjoin.cpp | 2 +- src/modules/m_spanningtree/fmode.cpp | 2 +- src/modules/m_spanningtree/ftopic.cpp | 2 +- src/modules/m_spanningtree/idle.cpp | 2 +- src/modules/m_spanningtree/ijoin.cpp | 4 +- src/modules/m_spanningtree/main.cpp | 6 +- src/modules/m_spanningtree/main.h | 14 ++-- src/modules/m_spanningtree/metadata.cpp | 2 +- src/modules/m_spanningtree/misccommands.cpp | 4 +- src/modules/m_spanningtree/nick.cpp | 2 +- src/modules/m_spanningtree/num.cpp | 8 +-- src/modules/m_spanningtree/opertype.cpp | 2 +- src/modules/m_spanningtree/override_map.cpp | 4 +- src/modules/m_spanningtree/override_squit.cpp | 2 +- src/modules/m_spanningtree/override_whois.cpp | 2 +- src/modules/m_spanningtree/ping.cpp | 2 +- src/modules/m_spanningtree/pong.cpp | 2 +- src/modules/m_spanningtree/postcommand.cpp | 4 +- src/modules/m_spanningtree/precommand.cpp | 2 +- src/modules/m_spanningtree/protocolinterface.cpp | 4 +- src/modules/m_spanningtree/protocolinterface.h | 4 +- src/modules/m_spanningtree/rconnect.cpp | 6 +- src/modules/m_spanningtree/rsquit.cpp | 4 +- src/modules/m_spanningtree/save.cpp | 2 +- src/modules/m_spanningtree/server.cpp | 12 ++-- src/modules/m_spanningtree/servercommand.cpp | 2 +- src/modules/m_spanningtree/servercommand.h | 8 +-- src/modules/m_spanningtree/sinfo.cpp | 2 +- src/modules/m_spanningtree/svsjoin.cpp | 4 +- src/modules/m_spanningtree/svsnick.cpp | 4 +- src/modules/m_spanningtree/svspart.cpp | 4 +- src/modules/m_spanningtree/treesocket.h | 16 ++--- src/modules/m_spanningtree/treesocket1.cpp | 2 +- src/modules/m_spanningtree/treesocket2.cpp | 10 +-- src/modules/m_spanningtree/uid.cpp | 10 +-- src/modules/m_spanningtree/utils.h | 2 +- src/modules/m_sqloper.cpp | 6 +- src/modules/m_sslinfo.cpp | 4 +- src/modules/m_starttls.cpp | 2 +- src/modules/m_svshold.cpp | 4 +- src/modules/m_swhois.cpp | 2 +- src/modules/m_timedbans.cpp | 4 +- src/modules/m_tline.cpp | 2 +- src/modules/m_topiclock.cpp | 4 +- src/modules/m_uhnames.cpp | 2 +- src/modules/m_uninvite.cpp | 4 +- src/modules/m_userip.cpp | 2 +- src/modules/m_vhost.cpp | 2 +- src/modules/m_watch.cpp | 2 +- 116 files changed, 273 insertions(+), 272 deletions(-) (limited to 'src/modules') diff --git a/src/modules/m_abbreviation.cpp b/src/modules/m_abbreviation.cpp index c81caf142..22baa916b 100644 --- a/src/modules/m_abbreviation.cpp +++ b/src/modules/m_abbreviation.cpp @@ -38,7 +38,7 @@ class ModuleAbbreviation : public Module return Version("Provides the ability to abbreviate commands a-la BBC BASIC keywords.",VF_VENDOR); } - ModResult OnPreCommand(std::string &command, std::vector ¶meters, LocalUser *user, bool validated, const std::string &original_line) CXX11_OVERRIDE + ModResult OnPreCommand(std::string& command, CommandBase::Params& parameters, LocalUser* user, bool validated, const std::string& original_line) CXX11_OVERRIDE { /* Command is already validated, has a length of 0, or last character is not a . */ if (validated || command.empty() || *command.rbegin() != '.') diff --git a/src/modules/m_alias.cpp b/src/modules/m_alias.cpp index 01338e8b4..a8e39cb47 100644 --- a/src/modules/m_alias.cpp +++ b/src/modules/m_alias.cpp @@ -129,7 +129,7 @@ class ModuleAlias : public Module return word; } - ModResult OnPreCommand(std::string &command, std::vector ¶meters, LocalUser *user, bool validated, const std::string &original_line) CXX11_OVERRIDE + ModResult OnPreCommand(std::string& command, CommandBase::Params& parameters, LocalUser* user, bool validated, const std::string& original_line) CXX11_OVERRIDE { /* If theyre not registered yet, we dont want * to know. @@ -328,7 +328,7 @@ class ModuleAlias : public Module } irc::tokenstream ss(result); - std::vector pars; + CommandBase::Params pars; std::string command, token; ss.GetToken(command); diff --git a/src/modules/m_alltime.cpp b/src/modules/m_alltime.cpp index de3e702ac..486ad1c18 100644 --- a/src/modules/m_alltime.cpp +++ b/src/modules/m_alltime.cpp @@ -29,7 +29,7 @@ class CommandAlltime : public Command flags_needed = 'o'; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { const std::string fmtdate = InspIRCd::TimeString(ServerInstance->Time(), "%Y-%m-%d %H:%M:%S", true); @@ -41,7 +41,7 @@ class CommandAlltime : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { return ROUTE_OPT_BCAST; } diff --git a/src/modules/m_blockamsg.cpp b/src/modules/m_blockamsg.cpp index 097041896..3c8fcd1b5 100644 --- a/src/modules/m_blockamsg.cpp +++ b/src/modules/m_blockamsg.cpp @@ -81,7 +81,7 @@ class ModuleBlockAmsg : public Module action = IBLOCK_KILLOPERS; } - ModResult OnPreCommand(std::string &command, std::vector ¶meters, LocalUser *user, bool validated, const std::string &original_line) CXX11_OVERRIDE + ModResult OnPreCommand(std::string& command, CommandBase::Params& parameters, LocalUser* user, bool validated, const std::string& original_line) CXX11_OVERRIDE { // Don't do anything with unregistered users if (user->registered != REG_ALL) diff --git a/src/modules/m_callerid.cpp b/src/modules/m_callerid.cpp index ecccbe91b..b0ec3b8ff 100644 --- a/src/modules/m_callerid.cpp +++ b/src/modules/m_callerid.cpp @@ -201,7 +201,7 @@ public: * /accept nick1,nick2,nick3,* * to add 3 nicks and then show your list */ - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { if (CommandParser::LoopCall(user, this, parameters, 0)) return CMD_SUCCESS; @@ -234,7 +234,7 @@ public: return (RemoveAccept(user, action.first) ? CMD_SUCCESS : CMD_FAILURE); } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { // There is a list in parameters[0] in two cases: // Either when the source is remote, this happens because 2.0 servers send comma seperated uuid lists, diff --git a/src/modules/m_cap.cpp b/src/modules/m_cap.cpp index 1465f8a38..80e70d3e5 100644 --- a/src/modules/m_cap.cpp +++ b/src/modules/m_cap.cpp @@ -365,7 +365,7 @@ class CommandCap : public SplitCommand works_before_reg = true; } - CmdResult HandleLocal(const std::vector& parameters, LocalUser* user) CXX11_OVERRIDE + CmdResult HandleLocal(LocalUser* user, const Params& parameters) CXX11_OVERRIDE { if (user->registered != REG_ALL) holdext.set(user, 1); diff --git a/src/modules/m_cban.cpp b/src/modules/m_cban.cpp index 7235a8bef..5f98def8f 100644 --- a/src/modules/m_cban.cpp +++ b/src/modules/m_cban.cpp @@ -85,7 +85,7 @@ class CommandCBan : public Command flags_needed = 'o'; this->syntax = " [ :]"; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { /* syntax: CBAN #channel time :reason goes here */ /* 'time' is a human-readable timestring, like 2d3h2s. */ @@ -132,7 +132,7 @@ class CommandCBan : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { if (IS_LOCAL(user)) return ROUTE_LOCALONLY; // spanningtree will send ADDLINE diff --git a/src/modules/m_cgiirc.cpp b/src/modules/m_cgiirc.cpp index 7d4f671b9..ecb07f96e 100644 --- a/src/modules/m_cgiirc.cpp +++ b/src/modules/m_cgiirc.cpp @@ -110,7 +110,7 @@ class CommandWebIRC : public SplitCommand this->syntax = "password gateway hostname ip"; } - CmdResult HandleLocal(const std::vector& parameters, LocalUser* user) CXX11_OVERRIDE + CmdResult HandleLocal(LocalUser* user, const Params& parameters) CXX11_OVERRIDE { if (user->registered == REG_ALL) return CMD_FAILURE; diff --git a/src/modules/m_check.cpp b/src/modules/m_check.cpp index f2da47f1b..cbb32db48 100644 --- a/src/modules/m_check.cpp +++ b/src/modules/m_check.cpp @@ -140,7 +140,7 @@ class CommandCheck : public Command return ret; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { if (parameters.size() > 1 && parameters[1] != ServerInstance->Config->ServerName) return CMD_SUCCESS; @@ -301,7 +301,7 @@ class CommandCheck : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { if ((parameters.size() > 1) && (parameters[1].find('.') != std::string::npos)) return ROUTE_OPT_UCAST(parameters[1]); diff --git a/src/modules/m_chghost.cpp b/src/modules/m_chghost.cpp index 10e447b45..6e498a8be 100644 --- a/src/modules/m_chghost.cpp +++ b/src/modules/m_chghost.cpp @@ -37,7 +37,7 @@ class CommandChghost : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { if (parameters[1].length() > ServerInstance->Config->Limits.MaxHost) { @@ -75,7 +75,7 @@ class CommandChghost : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_chgident.cpp b/src/modules/m_chgident.cpp index f09bef0ab..9a2d3b2ea 100644 --- a/src/modules/m_chgident.cpp +++ b/src/modules/m_chgident.cpp @@ -35,7 +35,7 @@ class CommandChgident : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); @@ -68,7 +68,7 @@ class CommandChgident : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_chgname.cpp b/src/modules/m_chgname.cpp index b6c59d36f..fa35732b8 100644 --- a/src/modules/m_chgname.cpp +++ b/src/modules/m_chgname.cpp @@ -33,7 +33,7 @@ class CommandChgname : public Command TRANSLATE2(TR_NICK, TR_TEXT); } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { User* dest = ServerInstance->FindNick(parameters[0]); @@ -64,7 +64,7 @@ class CommandChgname : public Command return CMD_SUCCESS; } - RouteDescriptor GetRouting(User* user, const std::vector& parameters) CXX11_OVERRIDE + RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE { return ROUTE_OPT_UCAST(parameters[0]); } diff --git a/src/modules/m_clearchan.cpp b/src/modules/m_clearchan.cpp index 0c6d52265..016d28737 100644 --- a/src/modules/m_clearchan.cpp +++ b/src/modules/m_clearchan.cpp @@ -35,7 +35,7 @@ class CommandClearChan : public Command force_manual_route = true; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { Channel* chan = activechan = ServerInstance->FindChan(parameters[0]); if (!chan) @@ -79,7 +79,7 @@ class CommandClearChan : public Command // The idea is that by the time our QUITs reach the next hop, it has already removed all their // clients from the channel, meaning victims on other servers won't see the victims on this // server quitting. - std::vector eparams; + CommandBase::Params eparams; eparams.push_back(chan->name); eparams.push_back(method); eparams.push_back(":"); diff --git a/src/modules/m_cloaking.cpp b/src/modules/m_cloaking.cpp index ad4b958c5..c277759d1 100644 --- a/src/modules/m_cloaking.cpp +++ b/src/modules/m_cloaking.cpp @@ -137,7 +137,7 @@ class CommandCloak : public Command syntax = ""; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE; + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE; }; class ModuleCloaking : public Module @@ -403,7 +403,7 @@ class ModuleCloaking : public Module } }; -CmdResult CommandCloak::Handle(const std::vector ¶meters, User *user) +CmdResult CommandCloak::Handle(User* user, const Params& parameters) { ModuleCloaking* mod = (ModuleCloaking*)(Module*)creator; irc::sockets::sockaddrs sa; diff --git a/src/modules/m_clones.cpp b/src/modules/m_clones.cpp index 7cce32188..68c9639c2 100644 --- a/src/modules/m_clones.cpp +++ b/src/modules/m_clones.cpp @@ -31,7 +31,7 @@ class CommandClones : public Command flags_needed = 'o'; syntax = ""; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { std::string clonesstr = "CLONES "; diff --git a/src/modules/m_close.cpp b/src/modules/m_close.cpp index 8ef93830d..b0b45b4b6 100644 --- a/src/modules/m_close.cpp +++ b/src/modules/m_close.cpp @@ -31,7 +31,7 @@ class CommandClose : public Command flags_needed = 'o'; } - CmdResult Handle(const std::vector& parameters, User* src) CXX11_OVERRIDE + CmdResult Handle(User* src, const Params& parameters) CXX11_OVERRIDE { std::map closed; diff --git a/src/modules/m_conn_umodes.cpp b/src/modules/m_conn_umodes.cpp index c439f3bfe..1f2fe7455 100644 --- a/src/modules/m_conn_umodes.cpp +++ b/src/modules/m_conn_umodes.cpp @@ -49,7 +49,7 @@ class ModuleModesOnConnect : public Module std::string buf; irc::spacesepstream ss(ThisModes); - std::vector modes; + CommandBase::Params modes; modes.push_back(user->nick); // split ThisUserModes into modes and mode params diff --git a/src/modules/m_conn_waitpong.cpp b/src/modules/m_conn_waitpong.cpp index 87b6b51f2..f9e9262a7 100644 --- a/src/modules/m_conn_waitpong.cpp +++ b/src/modules/m_conn_waitpong.cpp @@ -56,7 +56,7 @@ class ModuleWaitPong : public Module return MOD_RES_PASSTHRU; } - ModResult OnPreCommand(std::string &command, std::vector ¶meters, LocalUser* user, bool validated, const std::string &original_line) CXX11_OVERRIDE + ModResult OnPreCommand(std::string& command, CommandBase::Params& parameters, LocalUser* user, bool validated, const std::string& original_line) CXX11_OVERRIDE { if (command == "PONG") { diff --git a/src/modules/m_customtitle.cpp b/src/modules/m_customtitle.cpp index ea07ba7d0..c16b1eda2 100644 --- a/src/modules/m_customtitle.cpp +++ b/src/modules/m_customtitle.cpp @@ -40,7 +40,7 @@ class CommandTitle : public Command syntax = " "; } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { const std::string userHost = user->ident + "@" + user->GetRealHost(); const std::string userIP = user->ident + "@" + user->GetIPString(); diff --git a/src/modules/m_cycle.cpp b/src/modules/m_cycle.cpp index 1028fa977..3ead72a45 100644 --- a/src/modules/m_cycle.cpp +++ b/src/modules/m_cycle.cpp @@ -31,7 +31,7 @@ class CommandCycle : public SplitCommand Penalty = 3; syntax = " :[reason]"; } - CmdResult HandleLocal(const std::vector& parameters, LocalUser* user) CXX11_OVERRIDE + CmdResult HandleLocal(LocalUser* user, const Params& parameters) CXX11_OVERRIDE { Channel* channel = ServerInstance->FindChan(parameters[0]); std::string reason = "Cycling"; diff --git a/src/modules/m_dccallow.cpp b/src/modules/m_dccallow.cpp index 647f69e7a..04f85739a 100644 --- a/src/modules/m_dccallow.cpp +++ b/src/modules/m_dccallow.cpp @@ -114,7 +114,7 @@ class CommandDccallow : public Command /* XXX we need to fix this so it can work with translation stuff (i.e. move +- into a seperate param */ } - CmdResult Handle(const std::vector& parameters, User* user) CXX11_OVERRIDE + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE { /* syntax: DCCALLOW [+|-] (