From 9183ebd28c79b12ddf29b3847f59679e480af70a Mon Sep 17 00:00:00 2001 From: w00t Date: Thu, 11 Sep 2008 00:15:42 +0000 Subject: There is absolutely no need to cache connect timeout. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10512 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/inspsocket.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/inspsocket.cpp') diff --git a/src/inspsocket.cpp b/src/inspsocket.cpp index f3917bba0..7ce98ef8a 100644 --- a/src/inspsocket.cpp +++ b/src/inspsocket.cpp @@ -42,7 +42,7 @@ BufferedSocket::BufferedSocket(InspIRCd* SI, int newfd, const char* ip) this->Instance->SE->AddFd(this); } -BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip) +BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int aport, unsigned int maxtime, const std::string &connectbindip) { this->cbindip = connectbindip; this->fd = -1; @@ -80,8 +80,7 @@ BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int apor else { strlcpy(this->IP,host,MAXBUF); - timeout_val = maxtime; - if (!this->DoConnect()) + if (!this->DoConnect(maxtime)) { this->OnError(I_ERR_CONNECT); this->Close(); @@ -192,7 +191,7 @@ bool BufferedSocket::BindAddr(const std::string &ip) return true; } -bool BufferedSocket::DoConnect() +bool BufferedSocket::DoConnect(unsigned long maxtime) { /* The [2] is required because we may write a sockaddr_in6 here, and sockaddr_in6 is larger than sockaddr, where sockaddr_in4 is not. */ sockaddr* addr = new sockaddr[2]; @@ -272,7 +271,7 @@ bool BufferedSocket::DoConnect() return false; } - this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, timeout_val, this->Instance->Time()); + this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, maxtime, this->Instance->Time()); this->Instance->Timers->AddTimer(this->Timeout); } -- cgit v1.2.3