From 7d283ead756f22b2c659414b89938777ad97599f Mon Sep 17 00:00:00 2001 From: brain Date: Mon, 12 Dec 2005 22:29:06 +0000 Subject: Efficiency suggestion by w00t, faster processing of module sockets at the expense of a bit of ram git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@2357 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/inspircd.cpp | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) (limited to 'src/inspircd.cpp') diff --git a/src/inspircd.cpp b/src/inspircd.cpp index 5b4b8f5d1..ccf0257e7 100644 --- a/src/inspircd.cpp +++ b/src/inspircd.cpp @@ -121,6 +121,8 @@ char addrs[MAXBUF][255]; socklen_t length; char configToken[MAXBUF], Addr[MAXBUF], Type[MAXBUF]; +extern InspSocket* socket_ref[65535]; + time_t TIME = time(NULL), OLDTIME = time(NULL); SocketEngine* SE = NULL; @@ -2639,8 +2641,9 @@ int InspIRCd(char** argv, int argc) int incomingSockfd; userrec* cu = NULL; InspSocket* s = NULL; + InspSocket* s_del = NULL; char target[MAXBUF]; - unsigned int numsockets, numberactive; + unsigned int numberactive; /* Beta 7 moved all this stuff out of the main function * into smaller sub-functions, much tidier -- Brain @@ -2755,23 +2758,23 @@ int InspIRCd(char** argv, int argc) * Modules are encouraged to inherit their sockets from * InspSocket so we can process them neatly like this. */ - numsockets = module_sockets.size(); - for (std::vector::iterator a = module_sockets.begin(); a < module_sockets.end(); a++) + s = socket_ref[activefds[activefd]]; + + if ((s) && (!s->Poll())) { - s = (InspSocket*)*a; - if ((s) && (s->GetFd() == activefds[activefd])) + log(DEBUG,"Socket poll returned false, close and bail"); + SE->DelFd(s->GetFd()); + for (std::vector::iterator a = module_sockets.begin(); a < module_sockets.end(); a++) { - if (!s->Poll()) + s_del = (InspSocket*)*a; + if ((s_del) && (s_del->GetFd() == activefds[activefd])) { - log(DEBUG,"Socket poll returned false, close and bail"); - SE->DelFd(s->GetFd()); - s->Close(); module_sockets.erase(a); - delete s; break; } - if (module_sockets.size() != numsockets) break; } + s->Close(); + delete s; } break; -- cgit v1.2.3