From a018f26eddbc72fdbf87fe5ee89112a53311fff1 Mon Sep 17 00:00:00 2001 From: danieldg Date: Tue, 2 Mar 2010 03:17:04 +0000 Subject: DelFd should not fail, it will leave a bad dangling pointer in that case git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@12584 e03df62e-2008-0410-955e-edbf42e46eb7 --- include/socketengine.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'include') diff --git a/include/socketengine.h b/include/socketengine.h index e23c74de4..bba7bd399 100644 --- a/include/socketengine.h +++ b/include/socketengine.h @@ -302,18 +302,9 @@ public: * and false if it failed. This does not free the * EventHandler pointer using delete, if this is * required you must do this yourself. - * Note on forcing deletes. DO NOT DO THIS! This is - * extremely dangerous and will most likely render the - * socketengine dead. This was added only for handling - * very rare cases where broken 3rd party libs destroys - * the OS socket beyond our control. If you can't explain - * in minute details why forcing is absolutely necessary - * then you don't need it. That was a NO! * @param eh The event handler object to remove - * @param force *DANGEROUS* See method description! - * @return True if the event handler was removed */ - virtual bool DelFd(EventHandler* eh, bool force = false) = 0; + virtual void DelFd(EventHandler* eh) = 0; /** Returns true if a file descriptor exists in * the socket engine's list. -- cgit v1.2.3