From be69cdfc3df6fca67801cb614b162c7ceaa0b8bc Mon Sep 17 00:00:00 2001 From: brain Date: Tue, 31 Oct 2006 21:19:39 +0000 Subject: Dont worry this is only comments, not worth rebuilding for git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@5613 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/socketengine_kqueue.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/socketengine_kqueue.cpp b/src/socketengine_kqueue.cpp index 4abde652d..b3605b82b 100644 --- a/src/socketengine_kqueue.cpp +++ b/src/socketengine_kqueue.cpp @@ -145,12 +145,19 @@ int KQueueEngine::DispatchEvents() if (ke_list[j].flags & EV_EOF) { ServerInstance->Log(DEBUG,"kqueue: Error on FD %d", ke_list[j].ident); - /* Sneaky tricksy hobitses! */ + /* We love you kqueue, oh yes we do *sings*! + * kqueue gives us the error number directly in the EOF state! + * Unlike smelly epoll and select, where we have to getsockopt + * to get the error, this saves us time and cpu cycles. Go BSD! + */ ref[ke_list[j].ident]->HandleEvent(EVENT_ERROR, ke_list[j].fflags); continue; } if (ke_list[j].flags & EVFILT_WRITE) { + /* This looks wrong but its right. As above, theres no modify + * call in kqueue. See the manpage. + */ struct kevent ke; EV_SET(&ke, ke_list[j].ident, EVFILT_READ, EV_ADD, 0, 0, NULL); int i = kevent(EngineHandle, &ke, 1, 0, 0, NULL); -- cgit v1.2.3