m_spanningtree Bump protocol version and remove unused CAPAB CAPABILITIES entries

2 files changed, 24 insertions, 20 deletions

diff --git a/src/modules/m_spanningtree/capab.cpp b/src/modules/m_spanningtree/capab.cpp
index 039a3c5e7..fa10c79fe 100644
--- a/src/modules/m_spanningtree/capab.cpp
+++ b/src/modules/m_spanningtree/capab.cpp
@@ -132,6 +132,10 @@ void TreeSocket::SendCapabilities(int phase)
 		extra = " CHALLENGE=" + this->GetOurChallenge();
 	}
 
+	// 2.0 needs this key
+	if (proto_version == 1202)
+		extra.append(" PROTOCOL="+ConvToStr(ProtocolVersion));
+
 	this->WriteLine("CAPAB CAPABILITIES " /* Preprocessor does this one. */
 			":NICKMAX="+ConvToStr(ServerInstance->Config->Limits.NickMax)+
 			" CHANMAX="+ConvToStr(ServerInstance->Config->Limits.ChanMax)+
@@ -142,12 +146,11 @@ void TreeSocket::SendCapabilities(int phase)
 			" MAXKICK="+ConvToStr(ServerInstance->Config->Limits.MaxKick)+
 			" MAXGECOS="+ConvToStr(ServerInstance->Config->Limits.MaxGecos)+
 			" MAXAWAY="+ConvToStr(ServerInstance->Config->Limits.MaxAway)+
-			" IP6SUPPORT=1"+
-			" PROTOCOL="+ConvToStr(ProtocolVersion)+extra+
+			extra+
 			" PREFIX="+ServerInstance->Modes->BuildPrefixes()+
 			" CHANMODES="+ServerInstance->Modes->GiveModeList(MASK_CHANNEL)+
-			" USERMODES="+ServerInstance->Modes->GiveModeList(MASK_USER)+
-			" SVSPART=1");
+			" USERMODES="+ServerInstance->Modes->GiveModeList(MASK_USER)
+			);
 
 	this->WriteLine("CAPAB END");
 }
@@ -193,6 +196,22 @@ bool TreeSocket::Capab(const parameterlist &params)
 		capab->CapKeys.clear();
 		if (params.size() > 1)
 			proto_version = ConvToInt(params[1]);
+
+		if (proto_version < MinCompatProtocol)
+		{
+			SendError("CAPAB negotiation failed: Server is using protocol version " + (proto_version ? ConvToStr(proto_version) : "1201 or older")
+				+ " which is too old to link with this server (version " + ConvToStr(ProtocolVersion)
+				+ (ProtocolVersion != MinCompatProtocol ? ", links with " + ConvToStr(MinCompatProtocol) + " and above)" : ")"));
+			return false;
+		}
+
+		// Special case, may be removed in the future
+		if (proto_version == 1203 || proto_version == 1204)
+		{
+			SendError("CAPAB negotiation failed: InspIRCd 2.1 beta is not supported");
+			return false;
+		}
+
 		SendCapabilities(2);
 	}
 	else if (params[0] == "END")
@@ -240,21 +259,6 @@ bool TreeSocket::Capab(const parameterlist &params)
 			}
 		}
 
-		if (this->capab->CapKeys.find("PROTOCOL") == this->capab->CapKeys.end())
-		{
-			reason = "Protocol version not specified";
-		}
-		else
-		{
-			proto_version = ConvToInt(capab->CapKeys.find("PROTOCOL")->second);
-			if (proto_version < MinCompatProtocol)
-			{
-				reason = "Server is using protocol version " + ConvToStr(proto_version) +
-					" which is too old to link with this server (version " + ConvToStr(ProtocolVersion)
-					+ (ProtocolVersion != MinCompatProtocol ? ", links with " + ConvToStr(MinCompatProtocol) + " and above)" : ")");
-			}
-		}
-
 		if(this->capab->CapKeys.find("PREFIX") != this->capab->CapKeys.end() && this->capab->CapKeys.find("PREFIX")->second != ServerInstance->Modes->BuildPrefixes())
 			reason = "One or more of the prefixes on the remote server are invalid on this server.";
 
diff --git a/src/modules/m_spanningtree/main.h b/src/modules/m_spanningtree/main.h
index 937e908d3..8cc2d984f 100644
--- a/src/modules/m_spanningtree/main.h
+++ b/src/modules/m_spanningtree/main.h
@@ -34,7 +34,7 @@
  * Failure to document your protocol changes will result in a painfully
  * painful death by pain. You have been warned.
  */
-const long ProtocolVersion = 1202;
+const long ProtocolVersion = 1205;
 const long MinCompatProtocol = 1202;
 
 /** Forward declarations