Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 7 insertions, 11 deletions

diff --git a/src/modules/m_invisible.cpp b/src/modules/m_invisible.cpp
index 2e34b4f5d..c54014c85 100644
--- a/src/modules/m_invisible.cpp
+++ b/src/modules/m_invisible.cpp
@@ -130,18 +130,16 @@ class InvisibleDeOper : public ModeWatcher
 class ModuleInvisible : public Module
 {
  private:
-	InvisibleMode* qm;
-	InvisibleDeOper* ido;
+	InvisibleMode qm;
+	InvisibleDeOper ido;
  public:
 	ModuleInvisible(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), qm(Me), ido(Me)
 	{
 		conf = new ConfigReader(ServerInstance);
-		qm = new InvisibleMode(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(qm))
+		if (!ServerInstance->Modes->AddMode(&qm))
 			throw ModuleException("Could not add new modes!");
-		ido = new InvisibleDeOper(ServerInstance);
-		if (!ServerInstance->Modes->AddModeWatcher(ido))
+		if (!ServerInstance->Modes->AddModeWatcher(&ido))
 			throw ModuleException("Could not add new mode watcher on usermode +o!");
 
 		/* Yeah i know people can take this out. I'm not about to obfuscate code just to be a pain in the ass. */
@@ -152,10 +150,8 @@ class ModuleInvisible : public Module
 
 	virtual ~ModuleInvisible()
 	{
-		ServerInstance->Modes->DelMode(qm);
-		ServerInstance->Modes->DelModeWatcher(ido);
-		delete qm;
-		delete ido;
+		ServerInstance->Modes->DelMode(&qm);
+		ServerInstance->Modes->DelModeWatcher(&ido);
 		delete conf;
 	};