Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 3 insertions, 5 deletions

diff --git a/src/modules/m_cap.cpp b/src/modules/m_cap.cpp
index d70b32cde..2e9a24811 100644
--- a/src/modules/m_cap.cpp
+++ b/src/modules/m_cap.cpp
@@ -132,14 +132,12 @@ class CommandCAP : public Command
 
 class ModuleCAP : public Module
 {
-	CommandCAP* newcommand;
+	CommandCAP newcommand;
  public:
 	ModuleCAP(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), newcommand(Me, this)
 	{
-		// Create a new command
-		newcommand = new CommandCAP(ServerInstance, this);
-		ServerInstance->AddCommand(newcommand);
+		ServerInstance->AddCommand(&newcommand);
 
 		Implementation eventlist[] = { I_OnCheckReady };
 		ServerInstance->Modules->Attach(eventlist, this, 1);