Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 3 insertions, 4 deletions

diff --git a/src/modules/extra/m_ssl_gnutls.cpp b/src/modules/extra/m_ssl_gnutls.cpp
index f05a73227..b7b225384 100644
--- a/src/modules/extra/m_ssl_gnutls.cpp
+++ b/src/modules/extra/m_ssl_gnutls.cpp
@@ -110,12 +110,12 @@ class ModuleSSLGnuTLS : public Module
 	int clientactive;
 	bool cred_alloc;
 
-	CommandStartTLS* starttls;
+	CommandStartTLS starttls;
 
  public:
 
 	ModuleSSLGnuTLS(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), starttls(Me, this)
 	{
 		ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
@@ -135,8 +135,7 @@ class ModuleSSLGnuTLS : public Module
 			I_OnPostConnect, I_OnEvent, I_OnHookUserIO };
 		ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
-		starttls = new CommandStartTLS(ServerInstance, this);
-		ServerInstance->AddCommand(starttls);
+		ServerInstance->AddCommand(&starttls);
 	}
 
 	virtual void OnRehash(User* user)