diff options
| author | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-04-17 13:54:53 +0000 |
|---|---|---|
| committer | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-04-17 13:54:53 +0000 |
| commit | 2dfc384cde46ba63ed7c2f4420712596096123ca (patch) | |
| tree | 0427aad7d9f9c1655adb4022dc3c2c32ecb626d0 /include | |
| parent | c6f1e7997d846cabe33bb031d9d5fcf0790b83fa (diff) | |
Fix SetModeParam to use std::string and handle edge cases.
Previously, changing the vaule of a mode could require 3 calls to SetMode and SetModeParam.
This also fixes memory leaks caused by the strdup() not always being paired with a free().
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11307 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'include')
| -rw-r--r-- | include/channels.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/include/channels.h b/include/channels.h index afcdee41f..3bbcf0672 100644 --- a/include/channels.h +++ b/include/channels.h @@ -74,7 +74,7 @@ typedef CUList::const_iterator CUListConstIter; /** A list of custom modes parameters on a channel */ -typedef std::map<char,char*> CustomModeList; +typedef std::map<char,std::string> CustomModeList; /** used to hold a channel and a users modes on that channel, e.g. +v, +h, +o @@ -202,12 +202,12 @@ class CoreExport Channel : public Extensible */ void SetMode(char mode,bool mode_on); - /** Sets or unsets the parameters for a custom mode in a channels info + /** Sets or unsets a custom mode in the channels info * @param mode The mode character to set or unset - * @param parameter The parameter string to associate with this mode character - * @param mode_on True if you want to set the mode or false if you want to remove it + * @param parameter The parameter string to associate with this mode character. + * If it is empty, the mode is unset; if it is nonempty, the mode is set. */ - void SetModeParam(char mode,const char* parameter,bool mode_on); + void SetMode(char mode, std::string parameter); /** Returns true if a mode is set on a channel * @param mode The mode character you wish to query |