diff options
| author | Peter Powell <petpow@saberuk.com> | 2017-04-27 02:52:51 +0100 |
|---|---|---|
| committer | Peter Powell <petpow@saberuk.com> | 2017-04-27 02:52:51 +0100 |
| commit | 78b691e113e7e48fca0eb918591a17437fa0b96d (patch) | |
| tree | 9fe4d52b512177f72d5b5ba05f782635bffc302f | |
| parent | 41ef94bebb0fcb358150ff0179c6c55104827683 (diff) | |
Fix WEBIRC not rejecting invalid IP addresses.
| -rw-r--r-- | src/modules/m_cgiirc.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/modules/m_cgiirc.cpp b/src/modules/m_cgiirc.cpp index cce2e7855..d26c0bca1 100644 --- a/src/modules/m_cgiirc.cpp +++ b/src/modules/m_cgiirc.cpp @@ -73,6 +73,7 @@ class CommandWebirc : public Command realhost("cgiirc_realhost", Creator), realip("cgiirc_realip", Creator), webirc_hostname("cgiirc_webirc_hostname", Creator), webirc_ip("cgiirc_webirc_ip", Creator) { + allow_empty_last_param = false; works_before_reg = true; this->syntax = "password client hostname ip"; } @@ -81,6 +82,13 @@ class CommandWebirc : public Command if(user->registered == REG_ALL) return CMD_FAILURE; + irc::sockets::sockaddrs ipaddr; + if (!irc::sockets::aptosa(parameters[3], 0, ipaddr)) + { + ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s tried to use WEBIRC but gave an invalid IP address.", user->GetFullRealHost().c_str()); + return CMD_FAILURE; + } + for(CGIHostlist::iterator iter = Hosts.begin(); iter != Hosts.end(); iter++) { if(InspIRCd::Match(user->host, iter->hostmask, ascii_case_insensitive_map) || InspIRCd::MatchCIDR(user->GetIPString(), iter->hostmask, ascii_case_insensitive_map)) |