Changing by-value parameters to const references

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@3605 e03df62e-2008-0410-955e-edbf42e46eb7

2 files changed, 8 insertions, 9 deletions

diff --git a/include/users.h b/include/users.h
index 073ba3624..7d0864ffa 100644
--- a/include/users.h
+++ b/include/users.h
@@ -268,7 +268,7 @@ class userrec : public connection
 	 * This is done by looking up their oper type from userrec::oper, then referencing
 	 * this to their oper classes and checking the commands they can execute.
 	 */
-	bool HasPermission(std::string &command);
+	bool HasPermission(const std::string &command);
 
 	/** Calls read() to read some data for this user using their fd.
 	 */
@@ -281,7 +281,7 @@ class userrec : public connection
 	 * RFC-specified limit per line) then the method will return false and the
 	 * text will not be inserted.
 	 */
-	bool AddBuffer(std::string a);
+	bool AddBuffer(const std::string &a);
 
 	/** This method returns true if the buffer contains at least one carriage return
 	 * character (e.g. one complete line may be read)
@@ -306,7 +306,7 @@ class userrec : public connection
 	 * The WriteErrors of clients are checked at a more ideal time (in the mainloop) and
 	 * errored clients purged.
 	 */
-	void SetWriteError(std::string error);
+	void SetWriteError(const std::string &error);
 
 	/** Returns the write error which last occured on this connection or an empty string
 	 * if none occured.
@@ -318,7 +318,7 @@ class userrec : public connection
 	 * sendq value, SetWriteError() will be called to set the users error string to
 	 * "SendQ exceeded", and further buffer adds will be dropped.
 	 */
-	void AddWriteBuf(std::string data);
+	void AddWriteBuf(const std::string &data);
 
 	/** Flushes as much of the user's buffer to the file descriptor as possible.
 	 * This function may not always flush the entire buffer, rather instead as much of it
diff --git a/src/users.cpp b/src/users.cpp
index 3b6a10197..13146a086 100644
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -246,7 +246,7 @@ void userrec::RemoveInvite(irc::string &channel)
        	}
 }
 
-bool userrec::HasPermission(std::string &command)
+bool userrec::HasPermission(const std::string &command)
 {
 	char* mycmd;
 	char* savept;
@@ -295,7 +295,7 @@ bool userrec::HasPermission(std::string &command)
 }
 
 
-bool userrec::AddBuffer(std::string a)
+bool userrec::AddBuffer(const std::string &a)
 {
         std::string b = "";
 	char* n = (char*)a.c_str();
@@ -355,7 +355,7 @@ std::string userrec::GetBuffer()
         return ret;
 }
 
-void userrec::AddWriteBuf(std::string data)
+void userrec::AddWriteBuf(const std::string &data)
 {
 	if (*this->GetWriteError())
 		return;
@@ -397,7 +397,7 @@ void userrec::FlushWriteBuf()
 	}
 }
 
-void userrec::SetWriteError(std::string error)
+void userrec::SetWriteError(const std::string &error)
 {
 	log(DEBUG,"Setting error string for %s to '%s'",this->nick,error.c_str());
 	// don't try to set the error twice, its already set take the first string.
@@ -849,4 +849,3 @@ void force_nickchange(userrec* user,const char* newnick)
                 }
         }
 }
-