summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAttila Molnar <attilamolnar@hush.com>2015-11-23 12:52:03 +0100
committerAttila Molnar <attilamolnar@hush.com>2015-11-23 12:52:03 +0100
commitf3667d995e439a1d75fd9b56b29b610f3d877d8b (patch)
treee2f486a99bee4547b999714ad579adc72619f547
parent6fc00fa62905e5990fa9667f540e10a775832540 (diff)
Implement ExtensionItem::RegisterService()
-rw-r--r--include/extensible.h4
-rw-r--r--src/base.cpp6
-rw-r--r--src/modules.cpp4
3 files changed, 10 insertions, 4 deletions
diff --git a/include/extensible.h b/include/extensible.h
index a2c104377..3453f3e15 100644
--- a/include/extensible.h
+++ b/include/extensible.h
@@ -69,6 +69,10 @@ class CoreExport ExtensionItem : public ServiceProvider, public usecountbase
/** Free the item */
virtual void free(void* item) = 0;
+ /** Register this object in the ExtensionManager
+ */
+ void RegisterService() CXX11_OVERRIDE;
+
protected:
/** Get the item from the internal map */
void* get_raw(const Extensible* container) const;
diff --git a/src/base.cpp b/src/base.cpp
index 63b14256e..4111451f8 100644
--- a/src/base.cpp
+++ b/src/base.cpp
@@ -144,6 +144,12 @@ void* ExtensionItem::unset_raw(Extensible* container)
return rv;
}
+void ExtensionItem::RegisterService()
+{
+ if (!ServerInstance->Extensions.Register(this))
+ throw ModuleException("Extension already exists: " + name);
+}
+
bool ExtensionManager::Register(ExtensionItem* item)
{
return types.insert(std::make_pair(item->name, item)).second;
diff --git a/src/modules.cpp b/src/modules.cpp
index f5998f79c..ca13dad73 100644
--- a/src/modules.cpp
+++ b/src/modules.cpp
@@ -556,10 +556,6 @@ void ModuleManager::AddService(ServiceProvider& item)
{
switch (item.service)
{
- case SERVICE_METADATA:
- if (!ServerInstance->Extensions.Register(static_cast<ExtensionItem*>(&item)))
- throw ModuleException("Extension " + std::string(item.name) + " already exists.");
- return;
case SERVICE_DATA:
case SERVICE_IOHOOK:
{