From 4e167a8cc7dd4a135f23abee763763add28494fd Mon Sep 17 00:00:00 2001 From: Philip Hazel Date: Tue, 27 Jun 2006 14:04:29 +0000 Subject: Update error message for unknown ACL verb. --- doc/doc-txt/ChangeLog | 4 +++- src/src/acl.c | 5 +++-- test/log/0027 | 2 +- test/rejectlog/0027 | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog index 31feca73c..2f96604ba 100644 --- a/doc/doc-txt/ChangeLog +++ b/doc/doc-txt/ChangeLog @@ -1,4 +1,4 @@ -$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.357 2006/06/27 13:39:01 ph10 Exp $ +$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.358 2006/06/27 14:04:29 ph10 Exp $ Change log file for Exim from version 4.21 ------------------------------------------- @@ -39,6 +39,8 @@ PH/01 Added #define LDAP_DEPRECATED 1 to ldap.c because some of the "old" functions that Exim currently uses aren't defined in ldap.h for OpenLDAP without this. I don't know how relevant this is to other LDAP libraries. +PH/02 Add the verb name to the "unknown ACL verb" error. + Exim version 4.62 ----------------- diff --git a/src/src/acl.c b/src/src/acl.c index a8db4a75f..033291b0c 100644 --- a/src/src/acl.c +++ b/src/src/acl.c @@ -1,4 +1,4 @@ -/* $Cambridge: exim/src/src/acl.c,v 1.59 2006/06/07 15:06:26 fanf2 Exp $ */ +/* $Cambridge: exim/src/src/acl.c,v 1.60 2006/06/27 14:04:29 ph10 Exp $ */ /************************************************* * Exim - an Internet mail transport agent * @@ -720,7 +720,8 @@ while ((s = (*func)()) != NULL) { if (this == NULL) { - *error = string_sprintf("unknown ACL verb in \"%s\"", saveline); + *error = string_sprintf("unknown ACL verb \"%s\" in \"%s\"", name, + saveline); return NULL; } } diff --git a/test/log/0027 b/test/log/0027 index ffe01d6c0..280541371 100644 --- a/test/log/0027 +++ b/test/log/0027 @@ -5,7 +5,7 @@ 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny verify = header_syntax"@test.ex>: cannot check header contents in ACL for RCPT (only possible in ACL for DATA) 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny verify = junk"@test.ex>: expected "sender[=address]", "recipient", "helo", "header_syntax", "header_sender" or "reverse_host_lookup" at start of ACL condition "verify junk" 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny vorify = junk"@test.ex>: unknown ACL condition/modifier in "deny vorify = junk" -1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"dony verify = junk"@test.ex>: unknown ACL verb in "dony verify = junk" +1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"dony verify = junk"@test.ex>: unknown ACL verb "dony" in "dony verify = junk" 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny !message = abcd"@test.ex>: ACL error: negation is not allowed with "message" 1999-03-02 09:44:33 10HmaX-0005vi-00 U=CALLER F=<> temporarily rejected after DATA: cannot verify recipient in ACL for DATA (only possible for RCPT) 1999-03-02 09:44:33 10HmaY-0005vi-00 U=CALLER F=<> temporarily rejected after DATA: cannot test domains condition in DATA ACL diff --git a/test/rejectlog/0027 b/test/rejectlog/0027 index e1b7c0bfa..9a9421433 100644 --- a/test/rejectlog/0027 +++ b/test/rejectlog/0027 @@ -5,7 +5,7 @@ 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny verify = header_syntax"@test.ex>: cannot check header contents in ACL for RCPT (only possible in ACL for DATA) 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny verify = junk"@test.ex>: expected "sender[=address]", "recipient", "helo", "header_syntax", "header_sender" or "reverse_host_lookup" at start of ACL condition "verify junk" 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny vorify = junk"@test.ex>: unknown ACL condition/modifier in "deny vorify = junk" -1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"dony verify = junk"@test.ex>: unknown ACL verb in "dony verify = junk" +1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"dony verify = junk"@test.ex>: unknown ACL verb "dony" in "dony verify = junk" 1999-03-02 09:44:33 U=CALLER F=<> temporarily rejected RCPT <"deny !message = abcd"@test.ex>: ACL error: negation is not allowed with "message" 1999-03-02 09:44:33 10HmaX-0005vi-00 U=CALLER F=<> temporarily rejected after DATA: cannot verify recipient in ACL for DATA (only possible for RCPT) Envelope-from: <> -- cgit v1.2.3