summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2017-02-14Fix broken-in-queue messages predating CHUNKING fixPhil Pennock
util/chunking_fixqueue_finalnewlines.pl walks the queue, fixing any affected messages; see README.UPDATING. We're extremely cautious about operation failure. We do one check without locking messages, so that we can quickly skip past before trying to lock and contending with an actual delivery. Then we lock and do another fix. Note that we use flock, not fcntl, because that's what Perl makes readily available; we use an OS-guard to barf if the OS is not handled.
2017-02-14nit: document that `fout` must be open for reading tooPhil Pennock
2017-02-14Fix missing line termination on the last received BDAT chunk (Bug 1974)Heiko Schlittermann (HS12-RIPE)
2017-02-14Use enum { SEEN_LF, …} for ch_state(s)Heiko Schlittermann (HS12-RIPE)
2017-02-12Handle PKG_CONFIG_PATH in Local/MakefilePhil Pennock
Handle PKG_CONFIG_PATH, stripping whitespace expanding globs, collecting multiple sets and just build one variable, and use it in environment at configure time so that the libraries are found.
2017-02-12os_getcwd(): do not realloc if there was no malloc().Heiko Schlittermann (HS12-RIPE)
2017-02-12DKIM: fix crash with a verification when dkim disabled, under CHUNKINGJeremy Harris
2017-02-12Debug: avoid indenting line-prefixes (timestamp, pid, host-checking marker)Jeremy Harris
2017-02-12FreeBSD: only assume iconv for FreeBSD >= 10Phil Pennock
Since FreeBSD 10 is the oldest version of the OS supported by the FreeBSD Project, we shouldn't need this. But people are still using older versions. On closer examination, it's only been 6 weeks since 9.3 stopped being supported. People ignoring the status are playing with fire, getting no security updates, but let's not make that _our_ problem. Guard the "use system iconv" #define for the libiconv package with an OS version #ifdef.
2017-02-11Unbreak test_dbfn make-targetPhil Pennock
doc/dbm.discuss.txt describes how to make and use `test_dbfn` for testing DB functionality. Commit cf0812d5 adds a call to assert_no_variables into store.c which depends upon expand.c functionality and we can't link that in for test_dbfn without pulling in half of Exim. So adjust the test_dbfn target to rebuild store.o in COMPILE_UTILITY mode and link against that variant, then remove the custom-built store.o after the executable has been linked.
2017-02-11DNS: return explicit error code to caller on dnssec failure, for better loggingJeremy Harris
2017-02-11Mention FreeBSD/iconv in README.UPDATINGPhil Pennock
2017-02-10Compilation warnings shushingPhil Pennock
With this patch, in clang 3.4.1 we get no compilation complaints if Local/Makefile contains: CC=clang CFLAGS+=-Wno-dangling-else -Wno-logical-op-parentheses * In hash.c, for the OpenSSL case, use assert() to guard the paths which can't happen, instead of just assuming that the calling code never has a mistake * Fix some signed/unsigned issues * Be explicit about some ignored return values * Some parens around bit-twiddling * Use our os_getcwd with its extra guards in one place where getcwd was called * FreeBSD: use system iconv, safely, always (cherry picked from commit 845a3ced80964f562872aba841099adbc8933b40) Signed-off-by: Phil Pennock <pdp@exim.org>
2017-02-10perl paranoia about @INCPhil Pennock
2017-02-10TLS: rework error logging to pass more string back to caller for loggingJeremy Harris
This permits a library-sourced error to be associated with an address being delivered, collapsing pairs of log lines
2017-02-08Fix DKIM/GnuTLS buildJeremy Harris
Broken-by: e1d04f48a45c
2017-02-08Debug: indent ACL and expreassion tracing by evaluation depthJeremy Harris
2017-02-08DKIM: trim debug verbosityJeremy Harris
This tidies some buildfarm fails on animals buildding without DKIM
2017-02-08Fix non-contentscan buildJeremy Harris
Broken-by: 90341c71c19c
2017-02-08Memory management: drop variables identified as going out-of-scopeJeremy Harris
Fixes crash in transport re-using bad $sender_ip_address from callout
2017-02-08Memory management: when running under the testsuite, check every string ↵Jeremy Harris
variable on store_reset On spotting data in a region being freed, panic
2017-02-06CHUNKING: fix transport crash on temp-reject of pipelined non-first chunkJeremy Harris
2017-02-03DKIM: more care over untrustworthy data during verifyJeremy Harris
2017-02-03Fix no-SSL buildJeremy Harris
2017-02-02FreeBSD: Perl no longer in /usr/bin from PortsPhil Pennock
FreeBSD Ports by policy no longer allows symlinks in /usr/bin for things like Perl, so we have to look in /usr/local/bin for it instead.
2017-02-02GnuTLS: fix use of SHA3 hashesJeremy Harris
2017-01-31Handle Proxy Protocol v2 safely as well.Phil Pennock
We had test suite failures (test suite success!) because Proxy Protocol v2 (PPv2) wasn't being detected; by only reading 12 octets, the >= 16 check was failing. But in fact I had previously only fixed reading "only enough" for PPv1. Handling both PPv1 and PPv2 is complicated because the minimum valid length for PPv1 is 15 octets but for PPv2 the size to read is in the 15th and 16th octets. So refactored a little and we now use a total of 3 reads for the PPv2 case (assuming no fragmentation, etc; we'll actually keep reading now instead of aborting) to get the entire PPv2 header of exactly the right size, so that TLS handshake immediately following the PP header is not also swallowed. Fixes: 2018 Tested: manually, TLS and non-TLS, PPv1 and PPv2, all ways. Release: should be cherry-picked into 4.89RC series
2017-01-31Fix error logged for send failureJeremy Harris
Broken-by: de6273b487f1
2017-01-31Callouts: fix recipient verify/randomJeremy Harris
Broken-by: e9166683487c
2017-01-31Fix logging of drop-after-EHLO-reject.Jeremy Harris
An unset variable went wrong with clang, was fortuitously right with gcc.
2017-01-31Avoid using "-w" option in perl script shebang lines, being incompatible ↵Jeremy Harris
with "env perl"
2017-01-30Copyright year bumps for substantive changes 2017exim-4_89_RC1Phil Pennock
2017-01-30Avoid reading too much data before TLS handshakePhil Pennock
2017-01-30Fix size calculation, log unhandled amount.Phil Pennock
We did a `string_copy()` so `hdr.v1.line` is not the right base for an accurate size. Fix. Log unhanded amount. For clients waiting on the server before sending, this has to be 0. For clients speaking first (TLS) this can be non-zero.
2017-01-30Restrict address-parsing to a maximum of five layers of nested angle-brackets,Jeremy Harris
under main-option strip_excess_angle_brackets
2017-01-30Tidying: CoverityJeremy Harris
2017-01-29CHUNKING: Reject messages with malformed line ending. Bug 2000Jeremy Harris
Actually test only the first header line, but still do full line-ending canonicalisation on the remainder of the message in case a Evil Person slips past that.
2017-01-29TFO: remember setsockopt results, to condition non-transport client use. ↵Jeremy Harris
Bug 2027
2017-01-29Shuffle proxy-protocol to wrap TLS-on-connect startup. Bug 2018Jeremy Harris
2017-01-29DANE: fix build under LibreSSL. Bug 2020Kirill Miazine
2017-01-28Testsuite: add dnsdb testcase for defer when used in ACLJeremy Harris
2017-01-28LMDB: include filename in open-error messageJeremy Harris
2017-01-28DKIM: check pointer to calculated body hash before verify comparison. Bug 2029Jeremy Harris
We can have a missing body hash from a malformed DKIM-Signature: header
2017-01-28DKIM: rename variables for clarityJeremy Harris
2017-01-24Fix reception of (quoted) local-parts with embedded spaces. Bug 2025Jeremy Harris
2017-01-24TFO: Support compilation on Linus platforms which define TCP_FASTOPEN but ↵Jeremy Harris
not MSG_FASTOPEN
2017-01-24Define MIN and MAX for SolarisJeremy Harris
2017-01-23Fix build with OpenSSL, EXPERIMENTAL_DANE and DISABLE_EVENTJeremy Harris
2017-01-22DKIM: permit verify of sig blocks that sign other sig blocks. Bug 2014Jeremy Harris
2017-01-21Fix DKIM verify when used with CHUNKING. Bug 2016Jeremy Harris