diff options
| author | Jeremy Harris <jgh146exb@wizmail.org> | 2022-05-19 14:23:02 +0100 |
|---|---|---|
| committer | Jeremy Harris <jgh146exb@wizmail.org> | 2022-05-19 14:23:02 +0100 |
| commit | 8c74b00980bc7e3e479e8dfcd7c0008b2ac3f543 (patch) | |
| tree | 800bc3d1b95960827d855be118f3b24253042053 /src | |
| parent | c9771b0f607127d89018dd79bab6febb14db3d6d (diff) | |
GnuTLS: Do not free the cached creds on transport connection close. Bug 2886
Diffstat (limited to 'src')
| -rw-r--r-- | src/src/tls-gnu.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/src/tls-gnu.c b/src/src/tls-gnu.c index 875862cc1..30c8d40c0 100644 --- a/src/src/tls-gnu.c +++ b/src/src/tls-gnu.c @@ -1600,6 +1600,9 @@ return lifetime; /* Preload whatever creds are static, onto a transport. The client can then just copy the pointer as it starts up. */ +/*XXX this is not called for a cmdline send. But one needing to use >1 conn would benefit, +and there seems little downside. */ + static void tls_client_creds_init(transport_instance * t, BOOL watch) { @@ -3084,8 +3087,6 @@ if (rc != GNUTLS_E_SUCCESS) #endif (void) gnutls_alert_send_appropriate(state->session, rc); gnutls_deinit(state->session); - gnutls_certificate_free_credentials(state->lib_state.x509_cred); - state->lib_state = null_tls_preload; millisleep(500); shutdown(state->fd_out, SHUT_WR); for (int i = 1024; fgetc(smtp_in) != EOF && i > 0; ) i--; /* drain skt */ @@ -3778,9 +3779,6 @@ if (!ct_ctx) /* server */ } gnutls_deinit(state->session); -gnutls_certificate_free_credentials(state->lib_state.x509_cred); -state->lib_state = null_tls_preload; - tlsp->active.sock = -1; tlsp->active.tls_ctx = NULL; /* Leave bits, peercert, cipher, peerdn, certificate_verified set, for logging */ |