summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQualys Security Advisory <qsa@qualys.com>2021-02-21 18:54:16 -0800
committerHeiko Schlittermann (HS12-RIPE) <hs@schlittermann.de>2021-05-27 21:30:44 +0200
commit8761187029d998a942eaa1c0cc26592f52245446 (patch)
tree627afe3022a1e68ee929e28207729c95d556f5da
parentc7f4ea442a264b5cb3a9ef0eed641f4778dfb5b7 (diff)
CVE-2020-28025: Heap out-of-bounds read in pdkim_finish_bodyhash()
(cherry picked from commit cad30cd3fb96196e908e0d66b1b45fdf377c850c) (cherry picked from commit 1c261b90f627f0489f7dfcf1e66b46cce67f477d)
-rw-r--r--src/src/pdkim/pdkim.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/src/pdkim/pdkim.c b/src/src/pdkim/pdkim.c
index 0ad4d12d8..074106b5d 100644
--- a/src/src/pdkim/pdkim.c
+++ b/src/src/pdkim/pdkim.c
@@ -825,7 +825,7 @@ for (pdkim_signature * sig = ctx->sig; sig; sig = sig->next)
/* VERIFICATION --------------------------------------------------------- */
/* Be careful that the header sig included a bodyash */
- if ( sig->bodyhash.data
+ if (sig->bodyhash.data && sig->bodyhash.len == b->bh.len
&& memcmp(b->bh.data, sig->bodyhash.data, b->bh.len) == 0)
{
DEBUG(D_acl) debug_printf("DKIM [%s] Body hash compared OK\n", sig->domain);