summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Pennock <pdp@exim.org>2018-04-09 17:49:57 -0400
committerPhil Pennock <pdp@exim.org>2018-04-09 17:49:57 -0400
commit5e13fc5671fec5a1415b8d82a6344ceb71942478 (patch)
tree522a631e901cebdefcb2ffc7db9d2c232d0805ab
parent0c2250d167e858666f6ab372fe34dbd9e682932d (diff)
bugfix: heimdal interaction, check length
clang noted that taking the address of a struct member will never be 0, so checking against 0 was wrong. It was a `.length` member. I've compiled RC4 with this change and deployed it to my box and I can still authenticate fine.
-rw-r--r--src/src/auths/heimdal_gssapi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/src/auths/heimdal_gssapi.c b/src/src/auths/heimdal_gssapi.c
index c0611b895..eafdccc5c 100644
--- a/src/src/auths/heimdal_gssapi.c
+++ b/src/src/auths/heimdal_gssapi.c
@@ -357,7 +357,7 @@ auth_heimdal_gssapi_server(auth_instance *ablock, uschar *initial_data)
error_out = FAIL;
goto ERROR_OUT;
}
- if (&gbufdesc_out.length != 0) {
+ if (gbufdesc_out.length != 0) {
error_out = auth_get_data(&from_client,
gbufdesc_out.value, gbufdesc_out.length);
if (error_out != OK)