diff options
| author | Jeremy Harris <jgh146exb@wizmail.org> | 2021-05-12 15:01:12 +0100 |
|---|---|---|
| committer | Jeremy Harris <jgh146exb@wizmail.org> | 2021-05-12 15:01:12 +0100 |
| commit | 159cf206c97f876b07829d92db2217689745c1e8 (patch) | |
| tree | 86e641977ac3a31f5a78e7779b40c9e7aed81e3c | |
| parent | cd4a22176a7532ed1c8bd2b5c3f4c2c3e53bdf37 (diff) | |
Named Queues: fix immediate-delivery. Bug 2743
| -rw-r--r-- | doc/doc-txt/ChangeLog | 4 | ||||
| -rw-r--r-- | src/src/exim.c | 6 | ||||
| -rw-r--r-- | test/confs/0576 | 6 | ||||
| -rw-r--r-- | test/log/0576 | 3 | ||||
| -rw-r--r-- | test/scripts/0000-Basic/0576 | 4 |
5 files changed, 20 insertions, 3 deletions
diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog index c3fc01389..df6efeea3 100644 --- a/doc/doc-txt/ChangeLog +++ b/doc/doc-txt/ChangeLog @@ -247,8 +247,10 @@ JH/51 Taint-check ACL line. Previously, only filenames (for out-of-line ACL JH/52 Fix ${ip6norm:} operator. Previously, any trailing line text was dropped, making it unusable in complex expressions. - +JH/53 Bug 2743: fix immediate-delivery via named queue. Previously this would + fail with a taint-check on the spoolfile name, and leave the message + queued. Exim version 4.94 diff --git a/src/src/exim.c b/src/src/exim.c index 3e08f0376..fd1d87362 100644 --- a/src/src/exim.c +++ b/src/src/exim.c @@ -2784,9 +2784,11 @@ on the second character (the one after '-'), to save some effort. */ else badarg = TRUE; break; - /* -MCG: set the queue name, to a non-default value */ + /* -MCG: set the queue name, to a non-default value. Arguably, anything + from the commandline should be tainted - but we will need an untainted + value for the spoolfile when doing a -odi delivery process. */ - case 'G': if (++i < argc) queue_name = string_copy_taint(argv[i], TRUE); + case 'G': if (++i < argc) queue_name = string_copy_taint(argv[i], FALSE); else badarg = TRUE; break; diff --git a/test/confs/0576 b/test/confs/0576 index d6c0a1dc5..1b147aa45 100644 --- a/test/confs/0576 +++ b/test/confs/0576 @@ -7,6 +7,8 @@ SERVER = log_selector = +received_recipients +sender_on_delivery acl_smtp_rcpt = rcpt +acl_not_smtp_start = not_smtp + queue_only queue_run_in_order @@ -19,6 +21,10 @@ rcpt: queue = ${extract {$local_part} {normal="" alternate=alternate lowpri=lowpri}} logwrite = using queue '$queue_name' +not_smtp: + accept + queue = example + #--------------- begin routers diff --git a/test/log/0576 b/test/log/0576 index 246b10578..ddc28f932 100644 --- a/test/log/0576 +++ b/test/log/0576 @@ -28,6 +28,9 @@ 1999-03-02 09:44:33 10HmbC-0005vi-00 moved from (alternate) input, msglog to (third) input, msglog 1999-03-02 09:44:33 10HmbB-0005vi-00 moved from (third) input, msglog to input, msglog 1999-03-02 09:44:33 10HmbC-0005vi-00 moved from (third) input, msglog to input, msglog +1999-03-02 09:44:33 10HmbD-0005vi-00 <= CALLER@the.local.host.name U=CALLER P=local S=sss Q=example for q_set_by_nonsmtp_acl@test.ex +1999-03-02 09:44:33 10HmbD-0005vi-00 => q_set_by_nonsmtp_acl <q_set_by_nonsmtp_acl@test.ex> F=<CALLER@the.local.host.name> Q=example R=all T=dump +1999-03-02 09:44:33 10HmbD-0005vi-00 Completed ******** SERVER ******** 1999-03-02 09:44:33 exim x.yz daemon started: pid=pppp, -qGlowpri/3s, not listening for SMTP diff --git a/test/scripts/0000-Basic/0576 b/test/scripts/0000-Basic/0576 index ddf17f8d9..0f9a8c702 100644 --- a/test/scripts/0000-Basic/0576 +++ b/test/scripts/0000-Basic/0576 @@ -119,4 +119,8 @@ exim -bp -qGalternate exim -bp -qGthird **** # +# Immediate delivery, via alternate queue +exim -odi q_set_by_nonsmtp_acl@test.ex +**** +# no_stderr_check |