summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Pennock <pdp@exim.org>2011-03-22 07:01:52 -0400
committerPhil Pennock <pdp@exim.org>2011-03-22 07:01:52 -0400
commit754a0503134b184183f64c04ed30a3524fc3860b (patch)
treed5f942a4384852508536bd961eed1abd54f5bc9d
parent109066729a54f6ba5c4e8bc174133da33242e930 (diff)
Harmonised TLS library version reporting.
Only show if debugging. Layout now matches that introduced for other libraries in 4.74 PP/03.
-rw-r--r--doc/doc-txt/ChangeLog3
-rw-r--r--src/src/exim.c12
-rw-r--r--src/src/tls-gnu.c6
-rw-r--r--src/src/tls-openssl.c6
4 files changed, 15 insertions, 12 deletions
diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 94952afa5..820016310 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -8,6 +8,9 @@ Exim version 4.76
PP/01 The new ldap_require_cert option would segfault if used. Fixed.
+PP/02 Harmonised TLS library version reporting; only show if debugging.
+ Layout now matches that introduced for other libraries in 4.74 PP/03.
+
Exim version 4.75
-----------------
diff --git a/src/src/exim.c b/src/src/exim.c
index 3592f30dd..30974c9c6 100644
--- a/src/src/exim.c
+++ b/src/src/exim.c
@@ -912,14 +912,6 @@ if (fixed_never_users[0] > 0)
fprintf(f, "Size of off_t: " SIZE_T_FMT "\n", sizeof(off_t));
-/* This runtime check is to help diagnose library linkage mismatches which
-result in segfaults and the like; as such, it's left until the end,
-just in case. There will still be a "Configuration file is" line still to
-come. */
-#ifdef SUPPORT_TLS
-tls_version_report(f);
-#endif
-
/* Everything else is details which are only worth reporting when debugging.
Perhaps the tls_version_report should move into this too. */
DEBUG(D_any) do {
@@ -941,6 +933,10 @@ DEBUG(D_any) do {
fprintf(f, "Compiler: <unknown>\n");
#endif
+#ifdef SUPPORT_TLS
+ tls_version_report(f);
+#endif
+
#ifdef AUTH_CYRUS_SASL
auth_cyrus_sasl_version_report(f);
#endif
diff --git a/src/src/tls-gnu.c b/src/src/tls-gnu.c
index 8fcdd109d..23f8bd6ad 100644
--- a/src/src/tls-gnu.c
+++ b/src/src/tls-gnu.c
@@ -1326,8 +1326,10 @@ Returns: nothing
void
tls_version_report(FILE *f)
{
-fprintf(f, "GnuTLS compile-time version: %s\n", LIBGNUTLS_VERSION);
-fprintf(f, "GnuTLS runtime version: %s\n", gnutls_check_version(NULL));
+fprintf(f, "Library version: GnuTLS: Compile: %s\n"
+ " Runtime: %s\n",
+ LIBGNUTLS_VERSION,
+ gnutls_check_version(NULL));
}
/* End of tls-gnu.c */
diff --git a/src/src/tls-openssl.c b/src/src/tls-openssl.c
index b6a8dcb8c..e9628ba29 100644
--- a/src/src/tls-openssl.c
+++ b/src/src/tls-openssl.c
@@ -1081,8 +1081,10 @@ Returns: nothing
void
tls_version_report(FILE *f)
{
-fprintf(f, "OpenSSL compile-time version: %s\n", OPENSSL_VERSION_TEXT);
-fprintf(f, "OpenSSL runtime version: %s\n", SSLeay_version(SSLEAY_VERSION));
+fprintf(f, "Library version: OpenSSL: Compile: %s\n"
+ " Runtime: %s\n",
+ OPENSSL_VERSION_TEXT,
+ SSLeay_version(SSLEAY_VERSION));
}