diff options
| author | Jeremy Harris <jgh146exb@wizmail.org> | 2018-03-24 13:53:50 +0000 |
|---|---|---|
| committer | Jeremy Harris <jgh146exb@wizmail.org> | 2018-04-04 00:20:27 +0100 |
| commit | 47dc3814944d1b0365e196e1f48190fe220c2a5f (patch) | |
| tree | 1c2235ba5b54d9a77499f722ebb4a6f326ce6053 | |
| parent | abc01b4f3ea60198b92c397df5aa8c5cc2c07fb2 (diff) | |
ARC: give more detail with "bad signing-spec" message
| -rw-r--r-- | doc/doc-txt/experimental-spec.txt | 3 | ||||
| -rw-r--r-- | src/src/arc.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/doc/doc-txt/experimental-spec.txt b/doc/doc-txt/experimental-spec.txt index 3389632a2..bc5bab77d 100644 --- a/doc/doc-txt/experimental-spec.txt +++ b/doc/doc-txt/experimental-spec.txt @@ -802,7 +802,8 @@ arc_sign = <admd-identifier> : <selector> : <privkey> An option on the smtp transport, which constructs and prepends to the message an ARC set of headers. The textually-first Authentication-Results: header is used as a basis (you must have added one on entry to the ADMD). -Expanded; if unset, empty or forced-failure then no signing is done. +Expanded as a whole; if unset, empty or forced-failure then no signing is done. +If it is set, all three elements must be non-empty. diff --git a/src/src/arc.c b/src/src/arc.c index f4ae096bc..eb143b697 100644 --- a/src/src/arc.c +++ b/src/src/arc.c @@ -1536,7 +1536,8 @@ selector = string_nextinlist(&signspec, &sep, NULL, 0); if ( !*identity | !*selector || !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey) { - log_write(0, LOG_MAIN|LOG_PANIC, "ARC: bad signing-specification"); + log_write(0, LOG_MAIN|LOG_PANIC, "ARC: bad signing-specification (%s)", + !*identity ? "identity" : !*selector ? "selector" : "private-key"); return NULL; } if (*privkey == '/' && !(privkey = expand_file_big_buffer(privkey))) |